helper/resource: Deprecate Module Functionality

[bflad]

terraform-plugin-testing version

v1.1.0

Description

The helper/resource package from Terraform core originally helped test assertions with both providers and modules. When terraform-plugin-sdk split off from core, the module testing became extraneous due to its new context. Provider developers almost always can just test configurations within the root module. Bugs with module handling should be treated as core bugs, not provider developer concerns.

To verify the ecosystem is not depending on this functionality anymore, querying cs.github.com with filters such as TestCheckModuleNoResourceAttr language:Go NOT is:archived NOT is:fork shows:

TestCheckModuleNoResourceAttr - 0 usage
TestCheckModuleResourceAttr - 0 usage
TestCheckModuleResourceAttrPair - 0 usage
TestCheckModuleResourceAttrPtr - 0 usage
TestCheckModuleResourceAttrSet - 0 usage
TestModuleMatchResourceAttr - 0 usage

This code likely shouldn't have made the jump from terraform-plugin-sdk to terraform-plugin-testing, but it was not deprecated over in terraform-plugin-sdk before the migration. It is now released with compatibility promises so it must be treated the same as anything else under the versioning policy.

Proposal

Add Go documentation deprecation comments saying the functionality is deprecated without replacement and that any unknown existing use cases should contact this Go module's developers.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.