Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper/resource: Deprecate module-based TestCheckFunc #109

Merged
merged 3 commits into from
Mar 22, 2023
Merged

helper/resource: Deprecate module-based TestCheckFunc #109

merged 3 commits into from
Mar 22, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 22, 2023

Closes #98

@bflad bflad added this to the v1.2.0 milestone Mar 22, 2023
@bflad bflad requested a review from a team as a code owner March 22, 2023 14:51
austinvalle
austinvalle approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bflad bflad merged commit 3c3189e into main Mar 22, 2023
@bflad bflad deleted the bflad/deprecate-resource-module-helpers branch March 22, 2023 15:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

helper/resource: Deprecate Module Functionality
2 participants
@bflad @austinvalle