Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS resource ssm_activation, miss 'code' attribute #1565

Closed
SurviveLearnGrowRepeat opened this issue Sep 1, 2017 · 1 comment · Fixed by #1570
Closed

AWS resource ssm_activation, miss 'code' attribute #1565

SurviveLearnGrowRepeat opened this issue Sep 1, 2017 · 1 comment · Fixed by #1570

Comments

@SurviveLearnGrowRepeat
Copy link

SurviveLearnGrowRepeat commented Sep 1, 2017 •
edited
Loading

Terraform Version

Terraform v0.10.3

Affected Resource(s)

aws_ssm_activation

Expected Behavior

After the creation of the resource, they had to have a tag to obtain/consume/use the secret code generated.
Possibles names for the attribute: code, secret ...

Actual Behavior

The resource is created but without the 'code' attribute to use so, really the creation of aws_ssm_activation do not make any sense.
You can not use the new resource because the secret code is lost.

References

Git commit of the code that shows there is not exist an attribute to save the code value.
hashicorp/terraform@fc29875
@SurviveLearnGrowRepeat SurviveLearnGrowRepeat changed the title AWS resource ssm_activation, miss 'code' attribute AWS resource ssm_activation, miss 'code' attribute [bug] Sep 1, 2017
@SurviveLearnGrowRepeat SurviveLearnGrowRepeat changed the title AWS resource ssm_activation, miss 'code' attribute [bug] AWS resource ssm_activation, miss 'code' attribute Sep 1, 2017
stack72 added a commit to stack72/terraform-provider-aws that referenced this issue Sep 1, 2017
@stack72
resource/aws_ssm_activation: Export ssm activation activation_code
de329c2 
Fixes: hashicorp#1565

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMActivation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMActivation -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (41.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.999s
```
@stack72 stack72 mentioned this issue Sep 1, 2017
Merged
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this issue Sep 26, 2017
@stack72
resource/aws_ssm_activation: Export ssm activation activation_code
ecf237b 
Fixes: hashicorp#1565

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMActivation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMActivation -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (41.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.999s
```
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource/aws_ssm_activation: Export ssm activation activation_code stack72/terraform-provider-aws
1 participant
@SurviveLearnGrowRepeat