Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ssm_activation: Export ssm activation activation_code #1570

Merged

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Sep 1, 2017

Fixes: #1565

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMActivation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMActivation -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (41.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.999s

Fixes: hashicorp#1565

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMActivation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMActivation -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (41.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.999s
```
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMActivation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMActivation -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (35.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.738s

Thanks Paul! 👍

@Ninir Ninir merged commit 085a46e into hashicorp:master Sep 4, 2017
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
…ctivation-code

resource/aws_ssm_activation: Export ssm activation activation_code
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS resource ssm_activation, miss 'code' attribute
2 participants