Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/service/ec2: Implement DescribeManagedPrefixLists PreCheck for GovCloud #16804

Closed
bflad opened this issue Dec 17, 2020 · 2 comments · Fixed by #16806
Closed

tests/service/ec2: Implement DescribeManagedPrefixLists PreCheck for GovCloud #16804

bflad opened this issue Dec 17, 2020 · 2 comments · Fixed by #16806
Assignees
@bflad
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
v3.26.0

Comments

@bflad
Copy link
Contributor

bflad commented Dec 17, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It appears the EC2 DescribeManagedPrefixLists API Operation is not available in GovCloud, which can cause test failures with new functionality going in:

=== CONT  TestAccDataSourceAwsEc2ManagedPrefixList_filter
    data_source_aws_ec2_managed_prefix_list_test.go:100: Step 1/1 error: Error running pre-apply refresh:
        Error: error describing EC2 Managed Prefix Lists: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 7216f4c9-169f-4097-95ac-1bd62806bd30


=== CONT  TestAccDataSourceAwsEc2ManagedPrefixList_basic
    data_source_aws_ec2_managed_prefix_list_test.go:46: Step 1/1 error: Error running pre-apply refresh:
        Error: error describing EC2 Managed Prefix Lists: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: bf128192-6ee8-424b-ace3-09349efa30d2


=== CONT  TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany
    data_source_aws_ec2_managed_prefix_list_test.go:151: Step 1/1, expected an error with pattern, no match on: Error running pre-apply refresh:
        Error: error describing EC2 Managed Prefix Lists: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: e7e70397-1865-4b83-b569-c9800f1bf29f

Tracking issue to followup the implementation with a PreCheck to cover those.

Affected Resources

  • aws_ec2_managed_prefix_list

References
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Dec 17, 2020
@bflad bflad self-assigned this Dec 17, 2020
bflad added a commit that referenced this issue Dec 17, 2020
@bflad
tests/service/ec2: Add PreCheck for Managed Prefix Lists
4fae0f7 
Reference: #16804

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (3.65s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (20.74s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_filter (20.86s)

--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (21.32s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (22.83s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (23.06s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (35.60s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry (40.87s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (47.58s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_basic (1.74s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_filter (1.72s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (1.73s)

--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.74s)
```
@bflad bflad mentioned this issue Dec 17, 2020
Merged
bflad added a commit that referenced this issue Jan 27, 2021
@bflad
tests/service/ec2: Add PreCheck for Managed Prefix Lists (#16806)
3eb2033 
Reference: #16804

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (3.65s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (20.74s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_filter (20.86s)

--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (21.32s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (22.83s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (23.06s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (35.60s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry (40.87s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (47.58s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_basic (1.74s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_filter (1.72s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (1.73s)

--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.74s)
```
@github-actions github-actions bot added this to the v3.26.0 milestone Jan 27, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.26.0
Development

Successfully merging a pull request may close this issue.

tests/service/ec2: Add PreCheck for Managed Prefix Lists hashicorp/terraform-provider-aws
1 participant
@bflad