Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/service/ec2: Add PreCheck for Managed Prefix Lists #16806

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 17, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16804

Release note for CHANGELOG:

NONE

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (3.65s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (20.74s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_filter (20.86s)

--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (21.32s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (22.83s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (23.06s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (35.60s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry (40.87s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (47.58s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_basic (1.74s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_filter (1.72s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (1.73s)

--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.74s)

Reference: #16804

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (3.65s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (20.74s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_filter (20.86s)

--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (21.32s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (22.83s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (23.06s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (35.60s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry (40.87s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (47.58s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_basic (1.74s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_filter (1.72s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (1.73s)

--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry (1.73s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.75s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.74s)
```
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Dec 17, 2020
@bflad bflad requested a review from a team as a code owner December 17, 2020 03:49
@ghost ghost added size/S Managed by automation to categorize the size of a PR. labels Dec 17, 2020
Base automatically changed from master to main January 23, 2021 00:59
@YakDriver YakDriver self-assigned this Jan 27, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

GovCloud:

--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.60s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.60s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.60s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry (1.60s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.60s)
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.60s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_basic (1.60s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_filter (1.60s)
--- SKIP: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (1.60s)

us-west-2:

--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (3.91s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_filter (19.68s)
--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (20.53s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (20.58s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (24.91s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (24.92s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (31.47s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry (38.21s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (45.22s)

@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/service/ec2: Implement DescribeManagedPrefixLists PreCheck for GovCloud
2 participants