Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC matcher with gRPC protocol #17534

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Use gRPC matcher with gRPC protocol #17534

merged 4 commits into from
Feb 17, 2021

Conversation

bill-rich
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSLBTargetGroup_basic
=== PAUSE TestAccAWSLBTargetGroup_basic
=== RUN   TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== RUN   TestAccAWSLBTargetGroup_ProtocolVersion
=== PAUSE TestAccAWSLBTargetGroup_ProtocolVersion
=== RUN   TestAccAWSLBTargetGroup_withoutHealthcheck
=== PAUSE TestAccAWSLBTargetGroup_withoutHealthcheck
=== RUN   TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== PAUSE TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== RUN   TestAccAWSLBTargetGroup_Protocol_Geneve
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Geneve
=== RUN   TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol
=== RUN   TestAccAWSLBTargetGroup_Protocol_Tls
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Tls
=== RUN   TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck
=== PAUSE TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck
=== RUN   TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update
=== PAUSE TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update
=== RUN   TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== PAUSE TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== RUN   TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== RUN   TestAccAWSLBTargetGroup_BackwardsCompatibility
=== PAUSE TestAccAWSLBTargetGroup_BackwardsCompatibility
=== RUN   TestAccAWSLBTargetGroup_namePrefix
=== PAUSE TestAccAWSLBTargetGroup_namePrefix
=== RUN   TestAccAWSLBTargetGroup_generatedName
=== PAUSE TestAccAWSLBTargetGroup_generatedName
=== RUN   TestAccAWSLBTargetGroup_changeNameForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeNameForceNew
=== RUN   TestAccAWSLBTargetGroup_changeProtocolForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeProtocolForceNew
=== RUN   TestAccAWSLBTargetGroup_changePortForceNew
=== PAUSE TestAccAWSLBTargetGroup_changePortForceNew
=== RUN   TestAccAWSLBTargetGroup_changeVpcForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeVpcForceNew
=== RUN   TestAccAWSLBTargetGroup_tags
=== PAUSE TestAccAWSLBTargetGroup_tags
=== RUN   TestAccAWSLBTargetGroup_enableHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_enableHealthCheck
=== RUN   TestAccAWSLBTargetGroup_updateHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_updateHealthCheck
=== RUN   TestAccAWSLBTargetGroup_updateSticknessEnabled
=== PAUSE TestAccAWSLBTargetGroup_updateSticknessEnabled
=== RUN   TestAccAWSLBTargetGroup_defaults_application
=== PAUSE TestAccAWSLBTargetGroup_defaults_application
=== RUN   TestAccAWSLBTargetGroup_defaults_network
=== PAUSE TestAccAWSLBTargetGroup_defaults_network
=== RUN   TestAccAWSLBTargetGroup_stickinessDefaultNLB
=== PAUSE TestAccAWSLBTargetGroup_stickinessDefaultNLB
=== RUN   TestAccAWSLBTargetGroup_stickinessDefaultALB
=== PAUSE TestAccAWSLBTargetGroup_stickinessDefaultALB
=== RUN   TestAccAWSLBTargetGroup_stickinessValidNLB
=== PAUSE TestAccAWSLBTargetGroup_stickinessValidNLB
=== RUN   TestAccAWSLBTargetGroup_stickinessValidALB
=== PAUSE TestAccAWSLBTargetGroup_stickinessValidALB
=== RUN   TestAccAWSLBTargetGroup_stickinessInvalidNLB
=== PAUSE TestAccAWSLBTargetGroup_stickinessInvalidNLB
=== RUN   TestAccAWSLBTargetGroup_stickinessInvalidALB
=== PAUSE TestAccAWSLBTargetGroup_stickinessInvalidALB
=== CONT  TestAccAWSLBTargetGroup_basic
=== CONT  TestAccAWSLBTargetGroup_defaults_network
=== CONT  TestAccAWSLBTargetGroup_changePortForceNew
=== CONT  TestAccAWSLBTargetGroup_changeProtocolForceNew
=== CONT  TestAccAWSLBTargetGroup_defaults_application
=== CONT  TestAccAWSLBTargetGroup_updateSticknessEnabled
=== CONT  TestAccAWSLBTargetGroup_updateHealthCheck
=== CONT  TestAccAWSLBTargetGroup_enableHealthCheck
=== CONT  TestAccAWSLBTargetGroup_tags
=== CONT  TestAccAWSLBTargetGroup_changeVpcForceNew
=== CONT  TestAccAWSLBTargetGroup_stickinessValidNLB
=== CONT  TestAccAWSLBTargetGroup_stickinessValidALB
=== CONT  TestAccAWSLBTargetGroup_stickinessDefaultNLB
=== CONT  TestAccAWSLBTargetGroup_stickinessInvalidNLB
=== CONT  TestAccAWSLBTargetGroup_stickinessInvalidALB
=== CONT  TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck
=== CONT  TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== CONT  TestAccAWSLBTargetGroup_changeNameForceNew
=== CONT  TestAccAWSLBTargetGroup_Protocol_Tls
=== CONT  TestAccAWSLBTargetGroup_stickinessDefaultALB
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (22.55s)
=== CONT  TestAccAWSLBTargetGroup_generatedName
--- PASS: TestAccAWSLBTargetGroup_basic (24.78s)
=== CONT  TestAccAWSLBTargetGroup_ProtocolVersion
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (26.40s)
=== CONT  TestAccAWSLBTargetGroup_withoutHealthcheck
--- PASS: TestAccAWSLBTargetGroup_defaults_application (30.55s)
=== CONT  TestAccAWSLBTargetGroup_namePrefix
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (35.15s)
=== CONT  TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (13.94s)
=== CONT  TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (43.66s)
=== CONT  TestAccAWSLBTargetGroup_BackwardsCompatibility
--- PASS: TestAccAWSLBTargetGroup_defaults_network (44.16s)
=== CONT  TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update
--- PASS: TestAccAWSLBTargetGroup_generatedName (23.44s)
=== CONT  TestAccAWSLBTargetGroup_basicUdp
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (46.21s)
=== CONT  TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (48.72s)
=== CONT  TestAccAWSLBTargetGroup_Protocol_Geneve
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (32.73s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (27.34s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (64.85s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (66.01s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (69.54s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (28.69s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (74.12s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (74.13s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (77.05s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (79.57s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (45.36s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (36.05s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (40.79s)
--- PASS: TestAccAWSLBTargetGroup_tags (86.03s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (46.81s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (88.51s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (47.66s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (99.87s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (108.36s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (64.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	111.026s

@bill-rich bill-rich requested a review from a team as a code owner February 9, 2021 18:19
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 9, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 9, 2021
@bill-rich bill-rich mentioned this pull request Feb 9, 2021
Closed
@ewbankkit ewbankkit mentioned this pull request Feb 9, 2021
Closed
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Feb 16, 2021
@fivehole68
Copy link

@breathingdust
#16132 (comment)

Any chance this PR can jump up and replace my PR in the queue?

@YakDriver YakDriver self-assigned this Feb 17, 2021
YakDriver
YakDriver approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

GovCloud:

--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (34.60s)
--- PASS: TestAccAWSLBTargetGroup_basic (34.32s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (31.28s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (62.47s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (79.17s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (64.07s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (79.86s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (34.56s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (45.51s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (38.48s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (31.31s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (32.58s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (97.10s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (81.77s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (60.88s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (29.19s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (35.52s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (33.70s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (57.47s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (34.71s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (103.03s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (66.25s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (41.01s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (74.99s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (146.67s)
--- PASS: TestAccAWSLBTargetGroup_tags (94.94s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (63.94s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (84.43s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (101.20s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (18.73s)
--- SKIP: TestAccAWSLBTargetGroup_Protocol_Geneve (0.34s)

@bill-rich bill-rich merged commit d9e8492 into main Feb 17, 2021
@bill-rich bill-rich deleted the f-lb_grp_matcher branch February 17, 2021 01:24
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 17, 2021
github-actions bot pushed a commit that referenced this pull request Feb 17, 2021
Update CHANGELOG.md for #17534
18fda9d
heitorlessa added a commit to heitorlessa/terraform-provider-aws that referenced this pull request Feb 18, 2021
@heitorlessa
Merge branch 'main' of https://github.com/hashicorp/terraform-provide…
e1da594 
…r-aws into main

* 'main' of https://github.com/hashicorp/terraform-provider-aws: (599 commits)
  Adds CHANGELOG
  Updates acceptance tests and documentation
  Update CHANGELOG.md for hashicorp#17650
  Removes redundant error check
  Update CHANGELOG.md for hashicorp#17645
  resource/aws_lb_listener_certificate: Prevent resource ID parsing error with IAM Server Certificate names containing underscores (hashicorp#17645)
  resource/aws_instance: Apply attribute waiter logic to iam_instance_profile attribute (hashicorp#17414)
  Update CHANGELOG.md for hashicorp#17534
  Adds multi-error handling to ElastiCache Cluster sweeper
  Excludes Clusters in Replication Groups from sweeper
  Adds check for deleting only member of replication group and does not retry
  Update CHANGELOG.md for hashicorp#17204
  Update docs for cloudfront_distribution resource
  fix(aws_ses_reciept_rule): include period in name validation regex
  Add CHANGELOG entry.
  r/aws_dx_gateway_association: Fix 'TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount'.
  r/aws_ec2_transit_gateway: Increase deletion IncorrectState retry to 5 minutes.
  Update CHANGELOG.md after release
  fix if evaluation
  r/aws_dx_gateway_association: Modernize acceptance tests.
  ...
heitorlessa added a commit to heitorlessa/terraform-provider-aws that referenced this pull request Feb 18, 2021
@heitorlessa
Merge branch 'main' into feat/eventbridge_replay
f1a4348 
* main: (599 commits)
  Adds CHANGELOG
  Updates acceptance tests and documentation
  Update CHANGELOG.md for hashicorp#17650
  Removes redundant error check
  Update CHANGELOG.md for hashicorp#17645
  resource/aws_lb_listener_certificate: Prevent resource ID parsing error with IAM Server Certificate names containing underscores (hashicorp#17645)
  resource/aws_instance: Apply attribute waiter logic to iam_instance_profile attribute (hashicorp#17414)
  Update CHANGELOG.md for hashicorp#17534
  Adds multi-error handling to ElastiCache Cluster sweeper
  Excludes Clusters in Replication Groups from sweeper
  Adds check for deleting only member of replication group and does not retry
  Update CHANGELOG.md for hashicorp#17204
  Update docs for cloudfront_distribution resource
  fix(aws_ses_reciept_rule): include period in name validation regex
  Add CHANGELOG entry.
  r/aws_dx_gateway_association: Fix 'TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount'.
  r/aws_ec2_transit_gateway: Increase deletion IncorrectState retry to 5 minutes.
  Update CHANGELOG.md after release
  fix if evaluation
  r/aws_dx_gateway_association: Modernize acceptance tests.
  ...
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this pull request Feb 24, 2021
Closed
@jasonwalsh jasonwalsh mentioned this pull request Mar 16, 2021
Merged
1 task
@ghost
Copy link

ghost commented Mar 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bill-rich @fivehole68 @YakDriver @mike-hightail