Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proof of Concept] resources: Default tags implementation #17827

Closed
anGie44 opened this issue Feb 25, 2021 · 2 comments · Fixed by #17974
Closed

[Proof of Concept] resources: Default tags implementation #17827

anGie44 opened this issue Feb 25, 2021 · 2 comments · Fixed by #17974
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@anGie44
Copy link
Contributor

anGie44 commented Feb 25, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Placeholder for initial resource-level implementation of default_tags.

This will include support for provider-wide default_tags within 2 key resources. Support includes:

  • CustomizeDiff w/in resource definition to account for plan-time differences
  • tags_all Computed attribute
  • handling within CRUD operations
  • acceptance test coverage for the 4 use cases presented in Default tags for all resources #7926 (provider-level only, resource-only, overlapping, and non-overlapping tags)

New or Affected Resource(s)

  • aws_subnet
  • aws_vpc

References

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 25, 2021
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Feb 25, 2021
@anGie44 anGie44 changed the title [Proof of concept] resources: Default tags implementation [Proof of Concept] resources: Default tags implementation Feb 25, 2021
anGie44 added a commit that referenced this issue Mar 5, 2021
Mark ec2TagSpecificationsFromKeyValueTags with nolint until addressed in #17827
@anGie44 anGie44 added this to the v3.33.0 milestone Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
1 participant