Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proof of Concept] provider: default tags implementation #17941

Closed
wants to merge 1 commit into from
Closed

[Proof of Concept] provider: default tags implementation #17941

wants to merge 1 commit into from

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 5, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17826

Output from acceptance testing:

--- PASS: TestAccProvider_DefaultTags_Tags_One (5.33s)
--- PASS: TestAccProvider_DefaultTags_Tags_Multiple (5.34s)
--- PASS: TestAccProvider_DefaultTags_Tags_None (5.39s)
--- PASS: TestAccProvider_DefaultTags_EmptyConfigurationBlock (5.46s)

--- PASS: TestAccAWSProvider_Region_AwsChina (11.31s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (11.65s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (11.73s)
--- PASS: TestAccAWSProvider_Region_AwsC2S (11.75s)
--- PASS: TestAccAWSProvider_Region_AwsSC2S (12.66s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (13.84s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (13.84s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (13.84s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (13.96s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (14.06s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (14.18s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (14.20s)
--- PASS: TestAccAWSProvider_Endpoints (14.31s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (16.85s)

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 5, 2021
anGie44
anGie44 commented Mar 5, 2021
View reviewed changes
aws/tags.go Outdated Show resolved Hide resolved
anGie44 added a commit that referenced this pull request Mar 5, 2021
@anGie44
Update CHANGELOG for #17941;
b2da328 
Mark ec2TagSpecificationsFromKeyValueTags with nolint until addressed in #17827
anGie44
anGie44 commented Mar 5, 2021
View reviewed changes
aws/tags.go Outdated Show resolved Hide resolved
@anGie44 anGie44 marked this pull request as ready for review March 5, 2021 17:45
@anGie44 anGie44 requested a review from a team as a code owner March 5, 2021 17:45
@anGie44 anGie44 mentioned this pull request Mar 8, 2021
Merged
@anGie44 anGie44 force-pushed the f-provider-default-tags-poc branch from b2da328 to 6c32d5f Compare March 8, 2021 05:04
@anGie44 anGie44 changed the title provider: default tags support [Proof of Concept]provider: default tags implementation Mar 8, 2021
@anGie44 anGie44 changed the title [Proof of Concept]provider: default tags implementation [Proof of Concept] provider: default tags implementation Mar 8, 2021
@anGie44 anGie44 force-pushed the f-provider-default-tags-poc branch from 6c32d5f to 9c4f570 Compare March 8, 2021 05:12
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 8, 2021
@bflad bflad self-assigned this Mar 15, 2021
bflad
bflad suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far. 😄 Please see my notes below and reach out with any questions.

aws/internal/keyvaluetags/key_value_tags.go Show resolved Hide resolved
aws/internal/keyvaluetags/key_value_tags.go Show resolved Hide resolved
aws/provider_test.go Show resolved Hide resolved
.changelog/17941.txt Show resolved Hide resolved
anGie44 added a commit that referenced this pull request Mar 15, 2021
@anGie44
update per CR comments in #17941
1beda81
@anGie44
Copy link
Contributor Author

anGie44 commented Mar 15, 2021

Thanks again @bflad ! closing this in favor of cumulative changes in #17974

@anGie44 anGie44 closed this Mar 15, 2021
@anGie44 anGie44 added the proposal Proposes new design or functionality. label Mar 15, 2021
@anGie44 anGie44 deleted the f-provider-default-tags-poc branch March 17, 2021 04:07
@ghost
Copy link

ghost commented Apr 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad requested changes

Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proof of Concept] provider: Default tags implementation
2 participants
@anGie44 @bflad