Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource for Macie2 Custom Data Identifier #19254

Merged
merged 22 commits into from
May 7, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented May 5, 2021

Added a new resource, docs and tests for Macie Custom Data Identifier called aws_macie2_custom_data_identifier

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13432

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMacie2_serial'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMacie2_serial -timeout 180m
=== RUN   TestAccAWSMacie2_serial
=== RUN   TestAccAWSMacie2_serial/Account
=== RUN   TestAccAWSMacie2_serial/Account/basic
=== RUN   TestAccAWSMacie2_serial/Account/finding_publishing_frequency
=== RUN   TestAccAWSMacie2_serial/Account/status
=== RUN   TestAccAWSMacie2_serial/Account/finding_and_status
=== RUN   TestAccAWSMacie2_serial/Account/disappears
=== RUN   TestAccAWSMacie2_serial/ClassificationJob
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/disappears
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/status
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/complete
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/tags
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/basic
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/name_generated
=== RUN   TestAccAWSMacie2_serial/ClassificationJob/name_prefix
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier/tags
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier/basic
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier/name_generated
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier/name_prefix
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier/disappears
=== RUN   TestAccAWSMacie2_serial/CustomDataIdentifier/classification_job
--- PASS: TestAccAWSMacie2_serial (675.53s)
    --- PASS: TestAccAWSMacie2_serial/Account (134.91s)
        --- PASS: TestAccAWSMacie2_serial/Account/basic (21.18s)
        --- PASS: TestAccAWSMacie2_serial/Account/finding_publishing_frequency (33.05s)
        --- PASS: TestAccAWSMacie2_serial/Account/status (33.12s)
        --- PASS: TestAccAWSMacie2_serial/Account/finding_and_status (33.19s)
        --- PASS: TestAccAWSMacie2_serial/Account/disappears (14.37s)
    --- PASS: TestAccAWSMacie2_serial/ClassificationJob (349.89s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/disappears (36.00s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/status (66.51s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/complete (68.79s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/tags (67.57s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/basic (37.63s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/name_generated (36.56s)
        --- PASS: TestAccAWSMacie2_serial/ClassificationJob/name_prefix (36.84s)
    --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier (190.73s)
        --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/tags (37.45s)
        --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/basic (22.10s)
        --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/name_generated (21.83s)
        --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/name_prefix (16.03s)
        --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/disappears (21.85s)
        --- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/classification_job (71.47s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       675.574s

...

@coderGo93 coderGo93 requested a review from a team as a code owner May 5, 2021 23:33
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/macie2 Issues and PRs that pertain to the macie2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 5, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 5, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, @coderGo93! I have a few changes to make

aws/resource_aws_macie2_custom_data_identifier.go Outdated Show resolved Hide resolved
aws/resource_aws_macie2_custom_data_identifier.go Outdated Show resolved Hide resolved
aws/resource_aws_macie2_custom_data_identifier.go Outdated Show resolved Hide resolved
aws/resource_aws_macie2_custom_data_identifier.go Outdated Show resolved Hide resolved
aws/resource_aws_macie2_custom_data_identifier.go Outdated Show resolved Hide resolved
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label May 6, 2021
Edgar López added 3 commits May 6, 2021 18:22
… removed computed except for maximum distance, added validation when if custom data identifier is deleted should remove from state since it only soft deleted from the console/manual
@coderGo93 coderGo93 requested a review from gdavison May 7, 2021 03:03
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Acceptance test results

--- PASS: TestAccAWSMacie2_serial (339.61s)
--- PASS: TestAccAWSMacie2_serial/Account (85.89s)
--- PASS: TestAccAWSMacie2_serial/Account/basic (12.98s)
--- PASS: TestAccAWSMacie2_serial/Account/finding_publishing_frequency (21.49s)
--- PASS: TestAccAWSMacie2_serial/Account/status (21.00s)
--- PASS: TestAccAWSMacie2_serial/Account/finding_and_status (20.82s)
--- PASS: TestAccAWSMacie2_serial/Account/disappears (9.60s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob (156.98s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/name_generated (16.79s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/name_prefix (17.74s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/disappears (16.79s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/status (28.94s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/complete (28.84s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/tags (30.50s)
--- PASS: TestAccAWSMacie2_serial/ClassificationJob/basic (17.39s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier (96.74s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/classification_job (30.90s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/tags (16.67s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/basic (12.82s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/name_generated (12.84s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/name_prefix (10.06s)
--- PASS: TestAccAWSMacie2_serial/CustomDataIdentifier/disappears (13.45s)

@gdavison gdavison merged commit f87f609 into hashicorp:main May 7, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 7, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/macie2 Issues and PRs that pertain to the macie2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants