Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_macie2_custom_data_identifier: New resource #15408

Closed

Conversation

mattburgess
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13432
Release note for CHANGELOG:

New Resource: `aws_macie2_custom_data_identifier` (#13432)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMacie2CustomDataIdentifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMacie2CustomDataIdentifier -timeout 120m
=== RUN   TestAccAWSMacie2CustomDataIdentifier_basic
=== PAUSE TestAccAWSMacie2CustomDataIdentifier_basic
=== RUN   TestAccAWSMacie2CustomDataIdentifier_full
=== PAUSE TestAccAWSMacie2CustomDataIdentifier_full
=== CONT  TestAccAWSMacie2CustomDataIdentifier_basic
=== CONT  TestAccAWSMacie2CustomDataIdentifier_full
--- PASS: TestAccAWSMacie2CustomDataIdentifier_full (33.95s)
--- PASS: TestAccAWSMacie2CustomDataIdentifier_basic (34.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.306s

@mattburgess mattburgess requested a review from a team September 30, 2020 20:54
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/macie2 Issues and PRs that pertain to the macie2 service. labels Sep 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 30, 2020
@mattburgess mattburgess force-pushed the macie2-custom-data-identifier branch from eab44d9 to c5712f7 Compare September 30, 2020 21:12
Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@gdavison
Copy link
Contributor

gdavison commented May 7, 2021

Thanks for the PR, @mattburgess. We have someone implementing the whole Macie v2 service, so we've merged #19254 instead.

@gdavison gdavison closed this May 7, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/macie2 Issues and PRs that pertain to the macie2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants