Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Amazon Macie2 Support #13432

Closed
kamirendawkins opened this issue May 20, 2020 · 9 comments · Fixed by #19304
Closed

Feature Request: Amazon Macie2 Support #13432

kamirendawkins opened this issue May 20, 2020 · 9 comments · Fixed by #19304
Labels
new-resource Introduces a new resource. partition/aws-us-gov Pertains to the aws-us-gov partition. service/macie2 Issues and PRs that pertain to the macie2 service.
Milestone

Comments

@kamirendawkins
Copy link

kamirendawkins commented May 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As of May 13th a new Version of AWS Macie is available that is incompatible with existing Macie resources.

New or Affected Resource(s)

  • aws_macie2_classification_job
  • aws_macie2_custom_data_identifier
  • aws_macie2_findings_filter

Potential Terraform Configuration

# New Resource - not implemented
resource "aws_macie2_classification_job" "example" {
  name = ""
  description = ""
  job-type = ""
  custom_data_identifier_ids = []
  s3_job_definition = ""
  sampling_percentage = ""
  schedule_frequency = ""
  tags = ""
}

# New Resource - not implemented
resource "aws_macie2_custom_data_identifier" "example" {
  # ...
}

# New Resource - not implemented
resource "aws_macie2_findings_filter" "example" {
  # ...
}

References

@kamirendawkins kamirendawkins added the enhancement Requests to existing resources that expand the functionality or scope. label May 20, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 20, 2020
@kamirendawkins kamirendawkins changed the title Macie2 Support Feature Request: Macie2 Support May 20, 2020
@ewbankkit
Copy link
Contributor

From the Macie Classic FAQ:

Q: Can I still activate Macie Classic in new accounts?

No, you cannot activate Macie Classic in new accounts. However, you can still use Macie Classic with already activated accounts. You can reach out to AWS support if you have a unique situation and would like to activate Macie Classic in new accounts.

A first step is to note this in the current Macie resource documentation (and maybe rename the category to "Macie Classic" as that's how AWS are now branding Macie v1).

@cparmar
Copy link

cparmar commented Jun 9, 2020

The pricing for the service has been significantly reduced and the ability to administrate it using the terraform AWS provider would be great.

@ewbankkit ewbankkit added new-resource Introduces a new resource. service/macie Issues and PRs that pertain to the macie service. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jun 9, 2020
mattburgess added a commit to mattburgess/terraform-provider-aws that referenced this issue Sep 30, 2020
anGie44 added a commit that referenced this issue Sep 30, 2020
@anGie44
Copy link
Contributor

anGie44 commented Sep 30, 2020

Support for the macie2 service client has been merged and will be released with 3.9.0 of the Terraform AWS provider, likely out tomorrow.

@toddmichael
Copy link

Support for the macie2 service client has been merged and will be released with 3.9.0 of the Terraform AWS provider, likely out tomorrow.

@anGie44 appears this didn't make it into 3.9.0 or 3.10.0. Trying to sort out the reason, but I'm apparently not bright enough to do that today. Any ideas? Thank you!

@anGie44
Copy link
Contributor

anGie44 commented Oct 12, 2020

Hi @toddmichael and others following this issue! The support included in v3.9.0 of the Terraform AWS Provider is for the macie2 service client (merged in #15256 per New Service Implementation) but this does not include any new resources/data sources that may relate to this issue. At this time support for new resource/data-sources, such as that in #15408 (Custom Data Identifier), doesn’t have enough community support for the internal team to prioritize; nevertheless, we will continue to monitor the community interest in the features, and once enough support is demonstrated, the team will queue the PR(s) up for review.

@YakDriver YakDriver changed the title Feature Request: Macie2 Support Feature Request: Amazon Macie2 Support Mar 8, 2021
@ghost ghost added the service/macie2 Issues and PRs that pertain to the macie2 service. label Mar 8, 2021
@YakDriver YakDriver added partition/aws-us-gov Pertains to the aws-us-gov partition. service/macie2 Issues and PRs that pertain to the macie2 service. and removed service/macie2 Issues and PRs that pertain to the macie2 service. service/macie Issues and PRs that pertain to the macie service. labels Mar 8, 2021
@huntersneed
Copy link

Hey @anGie44 - thank you for helping drive this over the past few months. I can see it's been a while since there has been any update. Are you still waiting for community support in order to prioritize or is this now on the roadmap with a release in mind? Any information on the future state of this would be greatly appreciated!

@Zordrak
Copy link

Zordrak commented Mar 28, 2021

When this comes I will be very pleased, but I will not be able to make significant use of it unless the cross-account membership resources come with it. It has taken a very long time for SecurityHub cross-account membership to arrive, and I had to use the shell_script provider in a very suboptimal way to manage that relationship until recently. I really want to avoid re-introducing the shell script provider to manage macie2 cross-account membership.

AWS Organizations support for Macie2 is not an answer for me as AWS Organizations management of services is generally sub-standard, and is not manageable on a per-OU level.

So.. really looking forward to this, but please remember to copy and paste the guardduty/securityhub cross-account membership resources.

@ghost
Copy link

ghost commented May 19, 2021

This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. partition/aws-us-gov Pertains to the aws-us-gov partition. service/macie2 Issues and PRs that pertain to the macie2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants