Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for gp3 on aws_elasticsearch_domain ebs_options volume_type #26045

Closed
ryan-dyer-sp opened this issue Jul 29, 2022 · 5 comments · Fixed by #26175
Closed

Support for gp3 on aws_elasticsearch_domain ebs_options volume_type #26045

ryan-dyer-sp opened this issue Jul 29, 2022 · 5 comments · Fixed by #26175
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Milestone

Comments

@ryan-dyer-sp
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Elasticsearch now supports GP3 volume types. Please add functionality to support gp3 as a volume type.

New or Affected Resource(s)

aws_elasticsearch_domain

Potential Terraform Configuration

resource "aws_elasticsearch_domain" "domain" {
	ebs_options {
		volume_type = "gp3"
	}
}

References

https://docs.aws.amazon.com/opensearch-service/latest/developerguide/limits.html#ebsresource

@ryan-dyer-sp ryan-dyer-sp added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 29, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. labels Jul 29, 2022
@justinretzolk
Copy link
Member

Hey @ryan-dyer-sp 👋 Thank you for taking the time to raise this! The aws_elasticsearch_domain resource uses elasticsearch.VolumeType_Values() to validate the value passed to the volume_type argument. This function was updated yesterday in AWS Go SDK version 1.44.65 to include gp3, so this should work automatically in AWS Provider 4.25.0 when it's released.

@justinretzolk justinretzolk added this to the v4.25.0 milestone Jul 29, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 29, 2022
@ReadyElbow
Copy link

ReadyElbow commented Aug 3, 2022

@justinretzolk Thanks for quickly acting on this. Do you know if Terraform supports the advanced configuration options that GP3 supports?

Within the AWS GUI, we can control IOPs/Throughput. Terraform appears to support IOPs but not Throughput.

@ewbankkit
Copy link
Contributor

@ReadyElbow The throughput attribute will need to be added to the ebs_options configuration block.

@ewbankkit ewbankkit removed this from the v4.25.0 milestone Aug 4, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
nickolivera pushed a commit to nickolivera/terraform-provider-aws that referenced this issue Aug 8, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 10, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants