Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_elasticsearch_domain add throughput attr 26045 #26175

Merged

Conversation

nickolivera
Copy link
Contributor

@nickolivera nickolivera commented Aug 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26045

Output from acceptance testing:

nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_basic' PKG=opensearch ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 1  -run=TestAccOpenSearchDomainDataSource_Data_basic -timeout 180m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (1426.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 1428.214s

nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_advanced' PKG=opensearch ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 1  -run=TestAccOpenSearchDomainDataSource_Data_advanced -timeout 180m
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (1838.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 1840.528s


nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccOpenSearchDomain_VolumeType_update' PKG=opensearch ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 1  -run=TestAccOpenSearchDomain_VolumeType_update -timeout 180m
=== RUN   TestAccOpenSearchDomain_VolumeType_update
=== PAUSE TestAccOpenSearchDomain_VolumeType_update
=== CONT  TestAccOpenSearchDomain_VolumeType_update
--- PASS: TestAccOpenSearchDomain_VolumeType_update (3450.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 3451.857s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/opensearch Issues and PRs that pertain to the opensearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Aug 8, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 9, 2022
@github-actions github-actions bot added the service/elasticsearch Issues and PRs that pertain to the elasticsearch service. label Aug 10, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=600m make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_\|TestAccOpenSearchDomain_Volume\|TestAccOpenSearchDomain_basic' PKG=opensearch ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 3  -run=TestAccOpenSearchDomainDataSource_Data_\|TestAccOpenSearchDomain_Volume\|TestAccOpenSearchDomain_basic -timeout 600m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_VolumeType_update
=== PAUSE TestAccOpenSearchDomain_VolumeType_update
=== RUN   TestAccOpenSearchDomain_VolumeType_missing
=== PAUSE TestAccOpenSearchDomain_VolumeType_missing
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomain_VolumeType_update
=== CONT  TestAccOpenSearchDomain_VolumeType_missing
--- PASS: TestAccOpenSearchDomain_VolumeType_missing (1127.40s)
=== CONT  TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (1398.54s)
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomain_basic (1659.30s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (1884.96s)
--- PASS: TestAccOpenSearchDomain_VolumeType_update (3715.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	3719.229s
% ACCTEST_TIMEOUT=600m make testacc TESTARGS='-run=TestAccElasticsearchDomainDataSource_Data_\|TestAccElasticsearchDomain_UpdateVolume_type\|TestAccElasticsearchDomain_basic' PKG=elasticsearch ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticsearch/... -v -count 1 -parallel 3  -run=TestAccElasticsearchDomainDataSource_Data_\|TestAccElasticsearchDomain_UpdateVolume_type\|TestAccElasticsearchDomain_basic -timeout 600m
=== RUN   TestAccElasticsearchDomainDataSource_Data_basic
=== PAUSE TestAccElasticsearchDomainDataSource_Data_basic
=== RUN   TestAccElasticsearchDomainDataSource_Data_advanced
=== PAUSE TestAccElasticsearchDomainDataSource_Data_advanced
=== RUN   TestAccElasticsearchDomain_basic
=== PAUSE TestAccElasticsearchDomain_basic
=== RUN   TestAccElasticsearchDomain_UpdateVolume_type
=== PAUSE TestAccElasticsearchDomain_UpdateVolume_type
=== CONT  TestAccElasticsearchDomainDataSource_Data_basic
=== CONT  TestAccElasticsearchDomain_basic
=== CONT  TestAccElasticsearchDomainDataSource_Data_advanced
--- PASS: TestAccElasticsearchDomain_basic (1210.54s)
=== CONT  TestAccElasticsearchDomain_UpdateVolume_type
--- PASS: TestAccElasticsearchDomainDataSource_Data_basic (1502.67s)
--- PASS: TestAccElasticsearchDomainDataSource_Data_advanced (1915.32s)
--- PASS: TestAccElasticsearchDomain_UpdateVolume_type (3985.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	3989.600s

@ewbankkit
Copy link
Contributor

@nickyamanaka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 163ecab into hashicorp:main Aug 10, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 10, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/opensearch Issues and PRs that pertain to the opensearch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for gp3 on aws_elasticsearch_domain ebs_options volume_type
3 participants