Add fix for OpenSearch Serverless VPCE test #39454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
tests
jar-b
removed
the
needs-triage
|
We are seeing these failures in CI too: |
github-actions
bot
added
the
prioritized
|
@ewbankkit so are you looking into it then? We had introduced 2 new fields in the BatchGetVPCEResponse and need this to get merged in terraform too. |
|
There was a linting error. So raised another commit to fix it. |
The updated deprecation message now includes the impacted argument name,
providing clarity around what argument should be addressed.
```
│ Warning: Argument is deprecated
│
│ with aws_iam_role.test,
│ on main.tf line 33, in resource "aws_iam_role" "test":
│ 33: resource "aws_iam_role" "test" {
│
│ The inline_policy argument is deprecated. Use the aws_iam_role_policy resource instead. If Terraform should exclusively manage all inline policy associations (the current behavior
│ of this argument), use the aws_iam_role_policies_exclusive resource as well.
```
Add fix for OpenSearch Serverless VPCE test
mumoumit
force-pushed
the
f-fix-vpce-test
branch
from
327a696
to
7306c1b
Compare
|
Squashed the previous 2 commits into 1. |
ewbankkit
force-pushed
the
f-fix-vpce-test
branch
from
135af5b
to
aa8eaf9
Compare
# Conflicts: # internal/service/opensearchserverless/vpc_endpoint_test.go
ewbankkit
force-pushed
the
f-fix-vpce-test
branch
from
aa8eaf9
to
9dc286b
Compare
ewbankkit
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccOpenSearchServerlessVPCEndpoint' PKG=opensearchserverless ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/opensearchserverless/... -v -count 1 -parallel 3 -run=TestAccOpenSearchServerlessVPCEndpoint -timeout 360m
=== RUN TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== RUN TestAccOpenSearchServerlessVPCEndpoint_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_basic
=== RUN TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== RUN TestAccOpenSearchServerlessVPCEndpoint_update
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_update
=== RUN TestAccOpenSearchServerlessVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_disappears
=== CONT TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== CONT TestAccOpenSearchServerlessVPCEndpoint_update
=== CONT TestAccOpenSearchServerlessVPCEndpoint_disappears
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_disappears (327.64s)
=== CONT TestAccOpenSearchServerlessVPCEndpoint_securityGroups
--- PASS: TestAccOpenSearchServerlessVPCEndpointDataSource_basic (366.21s)
=== CONT TestAccOpenSearchServerlessVPCEndpoint_basic
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_update (574.60s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_basic (365.96s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_securityGroups (455.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless 788.962s
|
@mumoumit Thanks for the contribution 🎉 👏. |
|
Wanted to clarify BatchGetVpcEndpoint should return the security group IDs |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in the test code. When I ran the Acceptance test for VPCE I got this error:
Relations
Closes #33603.
Closes #39021.
Output from Acceptance Testing