r/aws_kinesis_analytics_application: Refactor tagging logic to keyvaluetags package

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 1 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== RUN   TestAccAWSKinesisAnalyticsApplication_tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_tags
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (29.09s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsMultiple
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (172.66s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_tags
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (87.40s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (89.43s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (50.17s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (61.02s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (73.10s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (164.74s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (109.33s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (89.81s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (88.84s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (166.37s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (112.32s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (110.11s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (49.44s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (56.76s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (70.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1580.952s

[bflad]

Looks good, thanks @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (13.66s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (19.23s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (19.77s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (26.51s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (27.61s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (29.40s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (38.26s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (40.50s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (48.25s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (65.46s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (65.76s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (66.61s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (73.56s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (76.13s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (76.21s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (122.41s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (122.61s)

[ghost]

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!