Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Ensure hashibot appropriately labels aws_vpn* as service/ec2 and aws_kinesis_analytics_* as service/kinesisanalytics #11355

Merged
merged 1 commit into from
Dec 20, 2019
Merged

provider: Ensure hashibot appropriately labels aws_vpn* as service/ec2 and aws_kinesis_analytics_* as service/kinesisanalytics #11355

merged 1 commit into from
Dec 20, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 18, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #11293
Reference: #11347
Reference: #11349

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

@bflad
provider: Ensure hashibot appropriately labels aws_vpn* as service/ec…
a3a1fb7 
…2 and aws_kinesis_analytics_* as service/kinesisanalytics

Reference: #11293
Reference: #11347
Reference: #11349
@bflad bflad requested a review from a team December 18, 2019 20:39
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Dec 18, 2019
@bflad bflad added provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2019
aeschright
aeschright approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v2.44.0 milestone Dec 20, 2019
@bflad bflad merged commit f21e296 into master Dec 20, 2019
@bflad bflad deleted the td-hashibot-labeling-vpn-kinesisanalytics branch December 20, 2019 02:39
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @aeschright