-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: Add Macie2 service client (#13432) #15256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mattburgess, thank you for this PR! One last addition and we should be set to go. In .hashibot.hcl
, let's also add the new service to behavior "pull_request_path_labeler" "service_labels" {
. for reference, the last bullet point in the New Service -> Service Client
section shows an example: https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service . If you have any questions, please let me know 😃
Thanks for the review @anGie44! Can't believe I missed that. Fix pushed. |
hi @mattburgess, thank you for pushing up the additional change to |
c8f4c89
to
b5a0fc3
Compare
Hi @anGie44 - I think I've rebased this correctly! I also looked at https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service again to make sure that there's nothing else I need to do with regard to the move away from vendoring and couldn't see anything. Let me know if I've missed anything though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're all set @mattburgess, thanks again! - CI checks all passing w/the rebase 👍
This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #13432
Release note for CHANGELOG:
Output from acceptance testing: