Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Add Macie2 service client (#13432) #15256

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

mattburgess
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13432

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@mattburgess mattburgess requested a review from a team September 21, 2020 21:09
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2020
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 24, 2020
@anGie44 anGie44 self-assigned this Sep 24, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattburgess, thank you for this PR! One last addition and we should be set to go. In .hashibot.hcl, let's also add the new service to behavior "pull_request_path_labeler" "service_labels" { . for reference, the last bullet point in the New Service -> Service Client section shows an example: https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service . If you have any questions, please let me know 😃

@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 25, 2020
@mattburgess
Copy link
Collaborator Author

Thanks for the review @anGie44! Can't believe I missed that. Fix pushed.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 26, 2020
@anGie44
Copy link
Contributor

anGie44 commented Sep 30, 2020

hi @mattburgess, thank you for pushing up the additional change to .hashibot.hcl! apologies that there is a conflict now in this PR -- we've since removed vendoring from this project and moved to utilizing go modules. do you mind rebasing? let me know if you have any followup questions 👍

@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 30, 2020
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Sep 30, 2020
@mattburgess
Copy link
Collaborator Author

Hi @anGie44 - I think I've rebased this correctly! I also looked at https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service again to make sure that there's nothing else I need to do with regard to the move away from vendoring and couldn't see anything. Let me know if I've missed anything though.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 30, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're all set @mattburgess, thanks again! - CI checks all passing w/the rebase 👍

@anGie44 anGie44 added this to the v3.9.0 milestone Sep 30, 2020
@anGie44 anGie44 merged commit a71d27a into hashicorp:master Sep 30, 2020
@mattburgess mattburgess deleted the add-macie2-client branch September 30, 2020 20:29
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants