Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: updating to Go 1.16 #17655

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR updates the AWS Provider to be built using Go 1.16, which adds support for Apple Silicon - as has been done in AzureAD and AzureRM so that we can launch support across different providers simultaneously.

@tombuildsstuff tombuildsstuff requested a review from a team as a code owner February 17, 2021 08:48
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 17, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 17, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@tombuildsstuff
Copy link
Contributor Author

@bflad looks like this also needs the environment variables updated for GHA, I'm assuming they're against the repo?

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 18, 2021
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 18, 2021
@bflad bflad self-assigned this Feb 18, 2021
@bflad
Copy link
Contributor

bflad commented Feb 18, 2021

We will likely wait to merge this until after this week's release so it can get a full acceptance test run in (and allow more time for Homebrew support of Go 1.16).

bflad added a commit that referenced this pull request Feb 18, 2021
Reference: https://github.com/goreleaser/goreleaser/releases/tag/v0.156.2
Reference: goreleaser/goreleaser#2069
Reference: #17655

This will likely be removed immediately after today's release and is just to prevent extraneous CI failures in the meantime.
bflad added a commit that referenced this pull request Feb 18, 2021
Reference: https://github.com/goreleaser/goreleaser/releases/tag/v0.156.2
Reference: goreleaser/goreleaser#2069
Reference: #17655

This will likely be removed immediately after today's release and is just to prevent extraneous CI failures in the meantime.
@bflad bflad mentioned this pull request Feb 18, 2021
5 tasks
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homebrew support is merged in and verified this locally using that. Thank you, @tombuildsstuff 🚀

@bflad bflad merged commit 7708be7 into hashicorp:main Feb 24, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 24, 2021
@tombuildsstuff tombuildsstuff deleted the f/go-1.16 branch February 25, 2021 10:09
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants