Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Temporarily disable darwin/arm64 builds for CI #17684

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 18, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: https://github.com/goreleaser/goreleaser/releases/tag/v0.156.2
Reference: goreleaser/goreleaser#2069
Reference: #17655

This will likely be removed immediately after today's release and is just to prevent extraneous CI failures in the meantime.

Output from acceptance testing: N/A (CI configuration)

Reference: https://github.com/goreleaser/goreleaser/releases/tag/v0.156.2
Reference: goreleaser/goreleaser#2069
Reference: #17655

This will likely be removed immediately after today's release and is just to prevent extraneous CI failures in the meantime.
@bflad bflad requested a review from a team as a code owner February 18, 2021 14:30
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 18, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty that brings tears to my eyes.

@bflad bflad merged commit d27e407 into main Feb 18, 2021
@bflad bflad deleted the t-goreleaser-temp-disable-darwin-arm64 branch February 18, 2021 14:43
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 18, 2021
@bflad bflad mentioned this pull request Feb 18, 2021
5 tasks
github-actions bot pushed a commit that referenced this pull request Feb 18, 2021
@pradeepbhadani
Copy link
Contributor

@bflad - goreleaser v0.157.0 now ignores darwin/arm64 if go<1.6 - https://github.com/goreleaser/goreleaser/releases/tag/v0.157.0

Raised PR to remove this ignore block -#17703

@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants