build(deps): bump github.com/golangci/golangci-lint from 1.35.2 to 1.37.1 in /tools #17743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.35.2 to 1.37.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.35.2...v1.37.1) Signed-off-by: dependabot[bot] <support@github.com>
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
bflad
added a commit
that referenced
this pull request
Feb 24, 2021
… impi handling in tools Go module, and update golangci-lint@v1.37.1 Reference: #17743 Reference: #17685 Reference: https://golang.org/doc/go1.16 This change request bundles a few related items around the Go 1.16 upgrade and changes to the `tools` Go module: * Removes `GO111MODULE=on` environment variable handling in GitHub Actions and GNUmakefile as that is now the default behavior in Go 1.16 * Adds missing `impi` into `tools/main.go` so it shows as needing to be versions * Upgrades `golangci-lint` in `tools` since dependabot has been having trouble with this change for some reason * Runs `go mod tidy` in `tools` with Go 1.16, which is the majority of the automatic updates in `tools/go.sum` Now with Go 1.16, we can use `go install PACKAGE@VERSION` if we no longer want to use the `tools` Go module strategy, however that will also remove dependabot pinging us on tooling updates.
|
Superseded by #17795 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.37.1
branch
|
Looks like the trouble here was similar to dependabot/dependabot-core#3073 |
bflad
added a commit
that referenced
this pull request
Feb 25, 2021
… impi handling in tools Go module, and update golangci-lint@v1.37.1 (#17795) Reference: #17743 Reference: #17685 Reference: https://golang.org/doc/go1.16 This change request bundles a few related items around the Go 1.16 upgrade and changes to the `tools` Go module: * Removes `GO111MODULE=on` environment variable handling in GitHub Actions and GNUmakefile as that is now the default behavior in Go 1.16 * Adds missing `impi` into `tools/main.go` so it shows as needing to be versions * Upgrades `golangci-lint` in `tools` since dependabot has been having trouble with this change for some reason * Runs `go mod tidy` in `tools` with Go 1.16, which is the majority of the automatic updates in `tools/go.sum` Now with Go 1.16, we can use `go install PACKAGE@VERSION` if we no longer want to use the `tools` Go module strategy, however that will also remove dependabot pinging us on tooling updates.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/golangci/golangci-lint from 1.35.2 to 1.37.1.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Commits
b39dbcddurationcheck: False positive when multiplying with int type struct field (#1...ea5f479exhaustivestruct: add missing settings (#1746)4b3fb4crevive: fix types and default configuration. (#1747)32e8517cyclop: add missing settings (#1743)9c47715Update doc for v1.37.0 (#1742)34e5fc6Use upstream gocyclo. (#1739)2121370add 'cyclop' linter (#1738)123da8eAdd go1.16 support (#1740)4dc0dc3build(deps): bump github.com/spf13/cobra from 1.1.1 to 1.1.3 (#1736)80ebe52build(deps): bump golangci/golangci-lint-action from v2.3.0 to v2.4.0 (#1735)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually