provider: Development and testing updates for Go 1.16 upgrade, proper impi handling in tools Go module, and update golangci-lint@v1.37.1 #17795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impi handling in tools Go module, and update golangci-lint@v1.37.1 Reference: #17743 Reference: #17685 Reference: https://golang.org/doc/go1.16 This change request bundles a few related items around the Go 1.16 upgrade and changes to the `tools` Go module: * Removes `GO111MODULE=on` environment variable handling in GitHub Actions and GNUmakefile as that is now the default behavior in Go 1.16 * Adds missing `impi` into `tools/main.go` so it shows as needing to be versions * Upgrades `golangci-lint` in `tools` since dependabot has been having trouble with this change for some reason * Runs `go mod tidy` in `tools` with Go 1.16, which is the majority of the automatic updates in `tools/go.sum` Now with Go 1.16, we can use `go install PACKAGE@VERSION` if we no longer want to use the `tools` Go module strategy, however that will also remove dependabot pinging us on tooling updates.
ghost
added
size/L
YakDriver
approved these changes
Feb 25, 2021
|
This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #17743
Reference: #17685
Reference: https://golang.org/doc/go1.16
This change request bundles a few related items around the Go 1.16 upgrade and changes to the
toolsGo module:GO111MODULE=onenvironment variable handling in GitHub Actions and GNUmakefile as that is now the default behavior in Go 1.16impiintotools/main.goso it shows as needing to be versioned in thetoolsGo modulegolangci-lintintoolssince dependabot has been having trouble with this change for some reasongo mod tidyintoolswith Go 1.16, which is the majority of the automatic updates intools/go.sumNow with Go 1.16, we can use
go install PACKAGE@VERSIONif we no longer want to use thetoolsGo module strategy, however that will also remove dependabot pinging us on tooling updates.Output from acceptance testing: N/A (CI)