New resource for Macie2 Account

[coderGo93]

Added a new resource, docs and tests for Macie2 Account called aws_macie2_account

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13432

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsMacie2Account_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsMacie2Account_ -timeout 180m
=== RUN   TestAccAwsMacie2Account_basic
--- PASS: TestAccAwsMacie2Account_basic (22.16s)
=== RUN   TestAccAwsMacie2Account_WithFinding
--- PASS: TestAccAwsMacie2Account_WithFinding (32.91s)
=== RUN   TestAccAwsMacie2Account_WithStatus
--- PASS: TestAccAwsMacie2Account_WithStatus (34.18s)
=== RUN   TestAccAwsMacie2Account_WithFindingAndStatus
--- PASS: TestAccAwsMacie2Account_WithFindingAndStatus (33.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       122.778s

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[github-actions]

Welcome @coderGo93 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[gdavison]

Hi @coderGo93, thanks for the PR. I have a number of changes we'd like to see. Some of them should have been caught by our linting tools, but it looks like the merge conflict prevented them from running.

We have a lot of documentation for contributing to the AWS provider located at https://github.com/hashicorp/terraform-provider-aws/tree/main/docs/contributing. Due to the age and size of the AWS provider, we have some older resources that don't necessarily follow the latest guidelines, so the documentation is a better guide than some of the existing resources.

[gdavison]

Hi @coderGo93, thanks for making the updates. I've added a few new comments, plus there are a number of changes left from the last review. In the cases where I've suggested an edit, you can apply them directly from GitHub or manually in your editor.

[gdavison]

It's looking good, @coderGo93! One more note about error handling on deletion, and we'll need a changelog file as described at https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/pullrequest-submission-and-lifecycle.md#changelog-process

[gdavison]

It's looking great! One last change that I missed.

[gdavison]

Looks good to me! 🚀

Acceptance test results

--- PASS: TestAccAwsMacie2Account_basic (39.97s)
--- PASS: TestAccAwsMacie2Account_FindingPublishingFrequency (66.07s)
--- PASS: TestAccAwsMacie2Account_WithStatus (69.27s)
--- PASS: TestAccAwsMacie2Account_WithFindingAndStatus (66.89s)
--- PASS: TestAccAwsMacie2Account_disappears (28.31s)

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.