Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the attribute "environment_id" to aws_appconfig_environment #20176

Merged
merged 1 commit into from
Jul 14, 2021
Merged

fix: add the attribute "environment_id" to aws_appconfig_environment #20176

merged 1 commit into from
Jul 14, 2021

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jul 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11973 #19307

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppConfigEnvironment'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigEnvironment -timeout 180m
=== RUN   TestAccAWSAppConfigEnvironment_basic
=== PAUSE TestAccAWSAppConfigEnvironment_basic
=== RUN   TestAccAWSAppConfigEnvironment_disappears
=== PAUSE TestAccAWSAppConfigEnvironment_disappears
=== RUN   TestAccAWSAppConfigEnvironment_updateName
=== PAUSE TestAccAWSAppConfigEnvironment_updateName
=== RUN   TestAccAWSAppConfigEnvironment_updateDescription
=== PAUSE TestAccAWSAppConfigEnvironment_updateDescription
=== RUN   TestAccAWSAppConfigEnvironment_Monitors
=== PAUSE TestAccAWSAppConfigEnvironment_Monitors
=== RUN   TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== PAUSE TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== RUN   TestAccAWSAppConfigEnvironment_Tags
=== PAUSE TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_basic
=== CONT  TestAccAWSAppConfigEnvironment_Monitors
=== CONT  TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== CONT  TestAccAWSAppConfigEnvironment_disappears
=== CONT  TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_updateName
=== CONT  TestAccAWSAppConfigEnvironment_updateDescription
--- PASS: TestAccAWSAppConfigEnvironment_disappears (85.40s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (102.00s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (141.55s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (164.41s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (178.14s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (186.54s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (204.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	206.613s

Add the attribute environment_id to aws_appconfig_environment.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/appconfig Issues and PRs that pertain to the appconfig service. size/XS Managed by automation to categorize the size of a PR. labels Jul 14, 2021
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review July 14, 2021 12:10
@suzuki-shunsuke
Copy link
Contributor Author

@anGie44 Would you review this? 🙏

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 14, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSAppConfigEnvironment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigEnvironment_ -timeout 180m
=== RUN   TestAccAWSAppConfigEnvironment_basic
=== PAUSE TestAccAWSAppConfigEnvironment_basic
=== RUN   TestAccAWSAppConfigEnvironment_disappears
=== PAUSE TestAccAWSAppConfigEnvironment_disappears
=== RUN   TestAccAWSAppConfigEnvironment_updateName
=== PAUSE TestAccAWSAppConfigEnvironment_updateName
=== RUN   TestAccAWSAppConfigEnvironment_updateDescription
=== PAUSE TestAccAWSAppConfigEnvironment_updateDescription
=== RUN   TestAccAWSAppConfigEnvironment_Monitors
=== PAUSE TestAccAWSAppConfigEnvironment_Monitors
=== RUN   TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== PAUSE TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== RUN   TestAccAWSAppConfigEnvironment_Tags
=== PAUSE TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_basic
=== CONT  TestAccAWSAppConfigEnvironment_Monitors
=== CONT  TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== CONT  TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_disappears
=== CONT  TestAccAWSAppConfigEnvironment_updateName
=== CONT  TestAccAWSAppConfigEnvironment_updateDescription
--- PASS: TestAccAWSAppConfigEnvironment_disappears (18.95s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (22.39s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (34.76s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (38.27s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (45.84s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (46.73s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (50.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.831s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSAppConfigEnvironment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigEnvironment_ -timeout 180m
=== RUN   TestAccAWSAppConfigEnvironment_basic
=== PAUSE TestAccAWSAppConfigEnvironment_basic
=== RUN   TestAccAWSAppConfigEnvironment_disappears
=== PAUSE TestAccAWSAppConfigEnvironment_disappears
=== RUN   TestAccAWSAppConfigEnvironment_updateName
=== PAUSE TestAccAWSAppConfigEnvironment_updateName
=== RUN   TestAccAWSAppConfigEnvironment_updateDescription
=== PAUSE TestAccAWSAppConfigEnvironment_updateDescription
=== RUN   TestAccAWSAppConfigEnvironment_Monitors
=== PAUSE TestAccAWSAppConfigEnvironment_Monitors
=== RUN   TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== PAUSE TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== RUN   TestAccAWSAppConfigEnvironment_Tags
=== PAUSE TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_basic
=== CONT  TestAccAWSAppConfigEnvironment_Monitors
=== CONT  TestAccAWSAppConfigEnvironment_updateDescription
=== CONT  TestAccAWSAppConfigEnvironment_updateName
=== CONT  TestAccAWSAppConfigEnvironment_disappears
=== CONT  TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_MultipleEnvironments
--- PASS: TestAccAWSAppConfigEnvironment_disappears (22.96s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (24.76s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (43.59s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (47.15s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (58.52s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (60.80s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (65.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.075s

@ewbankkit
Copy link
Contributor

@suzuki-shunsuke Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 83f75f2 into hashicorp:main Jul 14, 2021
@github-actions github-actions bot added this to the v3.50.0 milestone Jul 14, 2021
@suzuki-shunsuke
Copy link
Contributor Author

@ewbankkit Thank you for your quick review!

@suzuki-shunsuke suzuki-shunsuke deleted the fix/add-environment_id_attribute-to-appconfig_environment branch July 14, 2021 13:34
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/appconfig Issues and PRs that pertain to the appconfig service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants