-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add the attribute "environment_id" to aws_appconfig_environment #20176
fix: add the attribute "environment_id" to aws_appconfig_environment #20176
Conversation
@anGie44 Would you review this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSAppConfigEnvironment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigEnvironment_ -timeout 180m
=== RUN TestAccAWSAppConfigEnvironment_basic
=== PAUSE TestAccAWSAppConfigEnvironment_basic
=== RUN TestAccAWSAppConfigEnvironment_disappears
=== PAUSE TestAccAWSAppConfigEnvironment_disappears
=== RUN TestAccAWSAppConfigEnvironment_updateName
=== PAUSE TestAccAWSAppConfigEnvironment_updateName
=== RUN TestAccAWSAppConfigEnvironment_updateDescription
=== PAUSE TestAccAWSAppConfigEnvironment_updateDescription
=== RUN TestAccAWSAppConfigEnvironment_Monitors
=== PAUSE TestAccAWSAppConfigEnvironment_Monitors
=== RUN TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== PAUSE TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== RUN TestAccAWSAppConfigEnvironment_Tags
=== PAUSE TestAccAWSAppConfigEnvironment_Tags
=== CONT TestAccAWSAppConfigEnvironment_basic
=== CONT TestAccAWSAppConfigEnvironment_Monitors
=== CONT TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== CONT TestAccAWSAppConfigEnvironment_Tags
=== CONT TestAccAWSAppConfigEnvironment_disappears
=== CONT TestAccAWSAppConfigEnvironment_updateName
=== CONT TestAccAWSAppConfigEnvironment_updateDescription
--- PASS: TestAccAWSAppConfigEnvironment_disappears (18.95s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (22.39s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (34.76s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (38.27s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (45.84s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (46.73s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (50.73s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 53.831s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSAppConfigEnvironment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigEnvironment_ -timeout 180m
=== RUN TestAccAWSAppConfigEnvironment_basic
=== PAUSE TestAccAWSAppConfigEnvironment_basic
=== RUN TestAccAWSAppConfigEnvironment_disappears
=== PAUSE TestAccAWSAppConfigEnvironment_disappears
=== RUN TestAccAWSAppConfigEnvironment_updateName
=== PAUSE TestAccAWSAppConfigEnvironment_updateName
=== RUN TestAccAWSAppConfigEnvironment_updateDescription
=== PAUSE TestAccAWSAppConfigEnvironment_updateDescription
=== RUN TestAccAWSAppConfigEnvironment_Monitors
=== PAUSE TestAccAWSAppConfigEnvironment_Monitors
=== RUN TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== PAUSE TestAccAWSAppConfigEnvironment_MultipleEnvironments
=== RUN TestAccAWSAppConfigEnvironment_Tags
=== PAUSE TestAccAWSAppConfigEnvironment_Tags
=== CONT TestAccAWSAppConfigEnvironment_basic
=== CONT TestAccAWSAppConfigEnvironment_Monitors
=== CONT TestAccAWSAppConfigEnvironment_updateDescription
=== CONT TestAccAWSAppConfigEnvironment_updateName
=== CONT TestAccAWSAppConfigEnvironment_disappears
=== CONT TestAccAWSAppConfigEnvironment_Tags
=== CONT TestAccAWSAppConfigEnvironment_MultipleEnvironments
--- PASS: TestAccAWSAppConfigEnvironment_disappears (22.96s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (24.76s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (43.59s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (47.15s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (58.52s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (60.80s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (65.53s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 69.075s
@suzuki-shunsuke Thanks for the contribution 🎉 👏. |
@ewbankkit Thank you for your quick review! |
This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #11973 #19307
Output from acceptance testing:
Add the attribute
environment_id
toaws_appconfig_environment
.