Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_batch_compute_environment: Better error reporting when status is INVALID #21281

Merged
merged 1 commit into from
Oct 14, 2021
Merged

r/aws_batch_compute_environment: Better error reporting when status is INVALID #21281

merged 1 commit into from
Oct 14, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 13, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21262.
Closes #8549.

% make testacc TESTARGS='-run=TestAccAWSBatchComputeEnvironment_'                                                                         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBatchComputeEnvironment_ -timeout 180m
=== RUN   TestAccAWSBatchComputeEnvironment_basic
=== PAUSE TestAccAWSBatchComputeEnvironment_basic
=== RUN   TestAccAWSBatchComputeEnvironment_disappears
=== PAUSE TestAccAWSBatchComputeEnvironment_disappears
=== RUN   TestAccAWSBatchComputeEnvironment_NameGenerated
=== PAUSE TestAccAWSBatchComputeEnvironment_NameGenerated
=== RUN   TestAccAWSBatchComputeEnvironment_NamePrefix
=== PAUSE TestAccAWSBatchComputeEnvironment_NamePrefix
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== RUN   TestAccAWSBatchComputeEnvironment_createFargate
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargate
=== RUN   TestAccAWSBatchComputeEnvironment_createFargateSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargateSpot
=== RUN   TestAccAWSBatchComputeEnvironment_updateState
=== PAUSE TestAccAWSBatchComputeEnvironment_updateState
=== RUN   TestAccAWSBatchComputeEnvironment_updateServiceRole
=== PAUSE TestAccAWSBatchComputeEnvironment_updateServiceRole
=== RUN   TestAccAWSBatchComputeEnvironment_defaultServiceRole
=== PAUSE TestAccAWSBatchComputeEnvironment_defaultServiceRole
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_launchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== RUN   TestAccAWSBatchComputeEnvironment_Tags
=== PAUSE TestAccAWSBatchComputeEnvironment_Tags
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== CONT  TestAccAWSBatchComputeEnvironment_basic
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== CONT  TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== CONT  TestAccAWSBatchComputeEnvironment_Tags
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== CONT  TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== CONT  TestAccAWSBatchComputeEnvironment_launchTemplate
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== CONT  TestAccAWSBatchComputeEnvironment_defaultServiceRole
=== CONT  TestAccAWSBatchComputeEnvironment_updateServiceRole
=== CONT  TestAccAWSBatchComputeEnvironment_updateState
=== CONT  TestAccAWSBatchComputeEnvironment_createFargateSpot
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== CONT  TestAccAWSBatchComputeEnvironment_NameGenerated
=== CONT  TestAccAWSBatchComputeEnvironment_createFargate
=== CONT  TestAccAWSBatchComputeEnvironment_defaultServiceRole
    provider_test.go:874: skipping tests; missing IAM service-linked role /aws-service-role/batch. Please create the role and retry
--- SKIP: TestAccAWSBatchComputeEnvironment_defaultServiceRole (2.56s)
=== CONT  TestAccAWSBatchComputeEnvironment_NamePrefix
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (35.40s)
=== CONT  TestAccAWSBatchComputeEnvironment_disappears
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole (36.57s)
--- PASS: TestAccAWSBatchComputeEnvironment_basic (55.04s)
--- PASS: TestAccAWSBatchComputeEnvironment_createFargate (57.31s)
--- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (59.96s)
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (62.54s)
--- PASS: TestAccAWSBatchComputeEnvironment_NameGenerated (64.06s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (64.32s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage (71.47s)
--- PASS: TestAccAWSBatchComputeEnvironment_NamePrefix (70.28s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (74.71s)
--- PASS: TestAccAWSBatchComputeEnvironment_disappears (39.57s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (78.22s)
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (84.38s)
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate (87.18s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags (100.49s)
--- PASS: TestAccAWSBatchComputeEnvironment_Tags (107.67s)
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (108.39s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateServiceRole (125.10s)
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (236.29s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (500.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	503.632s
% TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_batch_compute_environment make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2 -sweep-run=aws_batch_compute_environment -timeout 60m
2021/10/13 14:06:16 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/13 14:06:16 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running..
2021/10/13 14:06:16 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-west-2)
2021/10/13 14:06:16 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/13 14:06:16 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:06:16 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:06:17 [DEBUG] Completed Sweeper (aws_batch_job_queue) in region (us-west-2) in 1.166059143s
2021/10/13 14:06:17 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2)
2021/10/13 14:06:18 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-249518938014937002)
2021/10/13 14:06:19 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:06:19 [ERROR] error deleting Batch Compute Environment (tf-acc-test-249518938014937002): error waiting for Batch Compute Environment (tf-acc-test-249518938014937002) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-249518938014937002 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: f0d3751d-8513-4fe7-ace1-6be1f239795c; Proxy: null)
2021/10/13 14:06:20 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-9132376917071342612)
2021/10/13 14:06:20 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:06:21 [ERROR] error deleting Batch Compute Environment (tf-acc-test-9132376917071342612): error waiting for Batch Compute Environment (tf-acc-test-9132376917071342612) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-9132376917071342612 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: 44bc6540-e6ce-4f1c-b4ea-7a50dad969fd; Proxy: null)
2021/10/13 14:06:21 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-1705481823449091672)
2021/10/13 14:06:21 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:06:22 [ERROR] error deleting Batch Compute Environment (tf-acc-test-1705481823449091672): error waiting for Batch Compute Environment (tf-acc-test-1705481823449091672) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-1705481823449091672 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: 828eef84-4f30-4350-a27a-25457dd66793; Proxy: null)
2021/10/13 14:06:34 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-7615333999760349610)
2021/10/13 14:06:34 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:06:34 [ERROR] error deleting Batch Compute Environment (tf-acc-test-7615333999760349610): error waiting for Batch Compute Environment (tf-acc-test-7615333999760349610) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-7615333999760349610 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: 5210ee1c-c0d3-4c21-88df-c32a0eeeb96b; Proxy: null)
2021/10/13 14:06:36 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-7492930073958672562)
2021/10/13 14:06:36 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:06:36 [ERROR] error deleting Batch Compute Environment (tf-acc-test-7492930073958672562): error waiting for Batch Compute Environment (tf-acc-test-7492930073958672562) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-7492930073958672562 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: c47af09e-77c1-4366-abd6-7cbff29929d5; Proxy: null)
2021/10/13 14:06:36 [DEBUG] Completed Sweeper (aws_batch_compute_environment) in region (us-west-2) in 19.590973311s
2021/10/13 14:06:36 [ERROR] Error running Sweeper (aws_batch_compute_environment) in region (us-west-2): 5 errors occurred:
	* error deleting Batch Compute Environment (tf-acc-test-249518938014937002): error waiting for Batch Compute Environment (tf-acc-test-249518938014937002) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-249518938014937002 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: f0d3751d-8513-4fe7-ace1-6be1f239795c; Proxy: null)
	* error deleting Batch Compute Environment (tf-acc-test-9132376917071342612): error waiting for Batch Compute Environment (tf-acc-test-9132376917071342612) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-9132376917071342612 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: 44bc6540-e6ce-4f1c-b4ea-7a50dad969fd; Proxy: null)
	* error deleting Batch Compute Environment (tf-acc-test-1705481823449091672): error waiting for Batch Compute Environment (tf-acc-test-1705481823449091672) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-1705481823449091672 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: 828eef84-4f30-4350-a27a-25457dd66793; Proxy: null)
	* error deleting Batch Compute Environment (tf-acc-test-7615333999760349610): error waiting for Batch Compute Environment (tf-acc-test-7615333999760349610) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-7615333999760349610 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: 5210ee1c-c0d3-4c21-88df-c32a0eeeb96b; Proxy: null)
	* error deleting Batch Compute Environment (tf-acc-test-7492930073958672562): error waiting for Batch Compute Environment (tf-acc-test-7492930073958672562) disable: unexpected state 'INVALID', wanted target 'VALID'. last error: CLIENT_ERROR - User: batch.amazonaws.com is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789012:role/tf-acc-test-7492930073958672562 (Service: AWSSecurityTokenService; Status Code: 403; Error Code: AccessDenied; Request ID: c47af09e-77c1-4366-abd6-7cbff29929d5; Proxy: null)

FAIL	github.com/terraform-providers/terraform-provider-aws/aws	23.977s
FAIL
make: *** [sweep] Error 1

@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR. labels Oct 13, 2021
@ewbankkit ewbankkit added the sweeper Pertains to changes to or issues with the sweeper. label Oct 13, 2021
@ewbankkit
Copy link
Contributor Author

After manually changing the IAM role for those compute environments:

% TEST=./aws SWEEP=us-east-1,us-east-2,us-west-1,us-west-2 SWEEPARGS=-sweep-run=aws_batch_compute_environment make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-east-1,us-east-2,us-west-1,us-west-2 -sweep-run=aws_batch_compute_environment -timeout 60m
2021/10/13 14:25:03 [DEBUG] Running Sweepers for region (us-east-1):
2021/10/13 14:25:03 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running..
2021/10/13 14:25:03 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-east-1)
2021/10/13 14:25:03 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/13 14:25:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:04 [DEBUG] Completed Sweeper (aws_batch_job_queue) in region (us-east-1) in 1.766924966s
2021/10/13 14:25:04 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-east-1)
2021/10/13 14:25:04 [DEBUG] Completed Sweeper (aws_batch_compute_environment) in region (us-east-1) in 139.507451ms
2021/10/13 14:25:04 [DEBUG] Sweeper (aws_batch_job_queue) already ran in region (us-east-1)
2021/10/13 14:25:04 Completed Sweepers for region (us-east-1) in 1.906697812s
2021/10/13 14:25:04 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_batch_job_queue
	- aws_batch_compute_environment
2021/10/13 14:25:04 [DEBUG] Running Sweepers for region (us-east-2):
2021/10/13 14:25:04 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running..
2021/10/13 14:25:04 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-east-2)
2021/10/13 14:25:04 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/13 14:25:04 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:05 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:05 [DEBUG] Completed Sweeper (aws_batch_job_queue) in region (us-east-2) in 529.749787ms
2021/10/13 14:25:05 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-east-2)
2021/10/13 14:25:05 [DEBUG] Completed Sweeper (aws_batch_compute_environment) in region (us-east-2) in 182.236757ms
2021/10/13 14:25:05 [DEBUG] Sweeper (aws_batch_job_queue) already ran in region (us-east-2)
2021/10/13 14:25:05 Completed Sweepers for region (us-east-2) in 712.318139ms
2021/10/13 14:25:05 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_batch_job_queue
	- aws_batch_compute_environment
2021/10/13 14:25:05 [DEBUG] Running Sweepers for region (us-west-1):
2021/10/13 14:25:05 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running..
2021/10/13 14:25:05 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-west-1)
2021/10/13 14:25:05 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/13 14:25:05 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:05 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:06 [DEBUG] Completed Sweeper (aws_batch_job_queue) in region (us-west-1) in 1.061497539s
2021/10/13 14:25:06 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-1)
2021/10/13 14:25:07 [DEBUG] Completed Sweeper (aws_batch_compute_environment) in region (us-west-1) in 384.103807ms
2021/10/13 14:25:07 [DEBUG] Sweeper (aws_batch_job_queue) already ran in region (us-west-1)
2021/10/13 14:25:07 Completed Sweepers for region (us-west-1) in 1.445751682s
2021/10/13 14:25:07 Sweeper Tests for region (us-west-1) ran successfully:
	- aws_batch_compute_environment
	- aws_batch_job_queue
2021/10/13 14:25:07 [DEBUG] Running Sweepers for region (us-west-2):
2021/10/13 14:25:07 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running..
2021/10/13 14:25:07 [DEBUG] Running Sweeper (aws_batch_job_queue) in region (us-west-2)
2021/10/13 14:25:07 [INFO] AWS Auth provider used: "EnvProvider"
2021/10/13 14:25:07 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:07 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/10/13 14:25:08 [DEBUG] Completed Sweeper (aws_batch_job_queue) in region (us-west-2) in 1.15792365s
2021/10/13 14:25:08 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2)
2021/10/13 14:25:08 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-249518938014937002)
2021/10/13 14:25:09 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:25:09 [DEBUG] Deleting Batch Compute Environment (tf-acc-test-249518938014937002)
2021/10/13 14:25:09 [DEBUG] Waiting for state to become: []
2021/10/13 14:25:10 [TRACE] Waiting 200ms before next try
2021/10/13 14:25:10 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-9132376917071342612)
2021/10/13 14:25:11 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:25:11 [DEBUG] Deleting Batch Compute Environment (tf-acc-test-9132376917071342612)
2021/10/13 14:25:12 [DEBUG] Waiting for state to become: []
2021/10/13 14:25:12 [TRACE] Waiting 200ms before next try
2021/10/13 14:25:13 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-1705481823449091672)
2021/10/13 14:25:13 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:25:14 [DEBUG] Deleting Batch Compute Environment (tf-acc-test-1705481823449091672)
2021/10/13 14:25:14 [DEBUG] Waiting for state to become: []
2021/10/13 14:25:14 [TRACE] Waiting 200ms before next try
2021/10/13 14:25:15 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-7615333999760349610)
2021/10/13 14:25:16 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:25:16 [DEBUG] Deleting Batch Compute Environment (tf-acc-test-7615333999760349610)
2021/10/13 14:25:17 [DEBUG] Waiting for state to become: []
2021/10/13 14:25:17 [TRACE] Waiting 200ms before next try
2021/10/13 14:25:18 [DEBUG] Disabling Batch Compute Environment (tf-acc-test-7492930073958672562)
2021/10/13 14:25:18 [DEBUG] Waiting for state to become: [VALID]
2021/10/13 14:25:18 [DEBUG] Deleting Batch Compute Environment (tf-acc-test-7492930073958672562)
2021/10/13 14:25:19 [DEBUG] Waiting for state to become: []
2021/10/13 14:25:19 [TRACE] Waiting 200ms before next try
2021/10/13 14:25:20 [DEBUG] Completed Sweeper (aws_batch_compute_environment) in region (us-west-2) in 12.104968785s
2021/10/13 14:25:20 [DEBUG] Sweeper (aws_batch_job_queue) already ran in region (us-west-2)
2021/10/13 14:25:20 Completed Sweepers for region (us-west-2) in 13.263281459s
2021/10/13 14:25:20 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_batch_job_queue
	- aws_batch_compute_environment
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.461s

@YakDriver YakDriver self-assigned this Oct 14, 2021
YakDriver
YakDriver approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (25.05s)
--- SKIP: TestAccAWSBatchComputeEnvironment_defaultServiceRole (0.51s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole (35.96s)
--- PASS: TestAccAWSBatchComputeEnvironment_createFargate (40.91s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (43.01s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage (52.80s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (54.01s)
--- PASS: TestAccAWSBatchComputeEnvironment_NamePrefix (55.52s)
--- PASS: TestAccAWSBatchComputeEnvironment_basic (58.97s)
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (60.61s)
--- PASS: TestAccAWSBatchComputeEnvironment_disappears (36.08s)
--- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (71.70s)
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate (71.71s)
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (74.80s)
--- PASS: TestAccAWSBatchComputeEnvironment_NameGenerated (81.67s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (83.21s)
--- PASS: TestAccAWSBatchComputeEnvironment_Tags (100.23s)
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (103.30s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateServiceRole (124.87s)
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (172.55s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags (177.48s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (471.50s)

@ewbankkit ewbankkit merged commit d13135a into main Oct 14, 2021
@ewbankkit ewbankkit deleted the b-aws_batch_compute_environment-error-reporting branch October 14, 2021 13:04
@github-actions github-actions bot added this to the v3.63.0 milestone Oct 14, 2021
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Milestone
v3.63.0
2 participants
@ewbankkit @YakDriver