Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance tests: Fix tests using acctest.FactoriesAlternate #29572

Merged
merged 31 commits into from
Feb 22, 2023
Merged

Acceptance tests: Fix tests using acctest.FactoriesAlternate #29572

merged 31 commits into from
Feb 22, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 22, 2023 •
edited
Loading

Description

Replaces acctest.FactoriesAlternate with acctest.ProtoV5FactoriesPlusProvidersAlternate which returns ProtoV5ProviderFactories (and hence can use Plugin Framework resources and data sources) plus *schema.Providers which can be used to make AWS API calls.

Also adds Context to additional acctest functions.

Relations

Closes #28858.
Relates #29005.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3Bucket_Replication_basic' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3Bucket_Replication_basic -timeout 180m
=== RUN   TestAccS3Bucket_Replication_basic
=== PAUSE TestAccS3Bucket_Replication_basic
=== CONT  TestAccS3Bucket_Replication_basic
--- PASS: TestAccS3Bucket_Replication_basic (50.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	55.249s

@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesMultipleRegions'.
5fb5d8b
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternateAccountAndAlternat…
a17f9c2 
…eRegion'.
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for account.
6912e30
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for appsync.
9a1fb01
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for backup.
3896e86
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for codepipeline.
088a5e8
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for detective.
1590a61
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for directconnect.
ddd39bd
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for dlm.
41e2f3d
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for ds.
a54528d
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for dynamodb.
c4c7b7e
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for ec2.
ab8c72c
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for globalaccele…
e5e77d9 
…rator.
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for guardduty.
e21ba1f
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for kms.
a1e0799
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for macie2.
11fda63
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for networkmanager.
91e3891
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for organizations.
b1d0864
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for ram.
16ba30a
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for rds.
bf76de9
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for redshift.
ab12b42
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for redshiftserv…
144fcb5 
…erless.
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for route53.
5a4fc65
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for route53resol…
e803f76 
…ver.
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for s3.
5b2f7b5
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for securityhub.
2222e8d
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate' for servicecatalog.
0e94efe
@ewbankkit
Add 'Context' to 'acctest.ProtoV5FactoriesAlternate'.
9833afb
@ewbankkit
Add 'Context' to 'acctest.FactoriesAlternate'.
dffb399
@ewbankkit
'acctest.FactoriesAlternate' -> 'acctest.ProtoV5FactoriesPlusProvider…
4f57448 
…sAlternate'.
@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. service/macie2 Issues and PRs that pertain to the macie2 service. service/neptune Issues and PRs that pertain to the neptune service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/opsworks Issues and PRs that pertain to the opsworks service. service/organizations Issues and PRs that pertain to the organizations service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/route53 Issues and PRs that pertain to the route53 service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/s3control Issues and PRs that pertain to the s3control service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/securityhub Issues and PRs that pertain to the securityhub service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/ssm Issues and PRs that pertain to the ssm service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Feb 22, 2023
@ewbankkit ewbankkit merged commit 9e579ab into main Feb 22, 2023
@ewbankkit ewbankkit deleted the t-fixup-acctest.FactoriesAlternate branch February 22, 2023 17:51
@github-actions github-actions bot added this to the v4.56.0 milestone Feb 22, 2023
@github-actions
Copy link

This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/account Issues and PRs that pertain to the account service. service/appsync Issues and PRs that pertain to the appsync service. service/backup Issues and PRs that pertain to the backup service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/detective Issues and PRs that pertain to the detective service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/docdb Issues and PRs that pertain to the docdb service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/efs Issues and PRs that pertain to the efs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/guardduty Issues and PRs that pertain to the guardduty service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/ipam Issues and PRs that pertain to the ipam service. service/kms Issues and PRs that pertain to the kms service. service/macie2 Issues and PRs that pertain to the macie2 service. service/neptune Issues and PRs that pertain to the neptune service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/opsworks Issues and PRs that pertain to the opsworks service. service/organizations Issues and PRs that pertain to the organizations service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/securityhub Issues and PRs that pertain to the securityhub service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/ssm Issues and PRs that pertain to the ssm service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.56.0
Development

Successfully merging this pull request may close these issues.

Acceptance tests using FactoriesAlternate can't use Plugin Framework data sources
1 participant
@ewbankkit