Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Reduce tags boilerplate code - Plugin SDK resources t* (Phase 3c) #30421

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 3, 2023

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=timestreamwrite ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/timestreamwrite/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccTimestreamWriteDatabase_basic
=== PAUSE TestAccTimestreamWriteDatabase_basic
=== RUN   TestAccTimestreamWriteDatabase_tags
=== PAUSE TestAccTimestreamWriteDatabase_tags
=== RUN   TestAccTimestreamWriteTable_basic
=== PAUSE TestAccTimestreamWriteTable_basic
=== RUN   TestAccTimestreamWriteTable_tags
=== PAUSE TestAccTimestreamWriteTable_tags
=== CONT  TestAccTimestreamWriteDatabase_basic
=== CONT  TestAccTimestreamWriteTable_basic
=== CONT  TestAccTimestreamWriteDatabase_tags
--- PASS: TestAccTimestreamWriteDatabase_basic (23.25s)
=== CONT  TestAccTimestreamWriteTable_tags
--- PASS: TestAccTimestreamWriteTable_basic (24.36s)
--- PASS: TestAccTimestreamWriteDatabase_tags (48.66s)
--- PASS: TestAccTimestreamWriteTable_tags (46.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	74.806s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (18.88s)
=== RUN   TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (36.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	64.098s
% make testacc TESTARGS='-run=TestAccTransfer_serial/^User$$\|^Server$$/^basic$$\|^tags$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/^User$\|^Server$/^basic$\|^tags$ -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/User
=== RUN   TestAccTransfer_serial/User/disappears
=== RUN   TestAccTransfer_serial/User/tags
=== RUN   TestAccTransfer_serial/User/HomeDirectoryMappings
=== RUN   TestAccTransfer_serial/User/ModifyWithOptions
=== RUN   TestAccTransfer_serial/User/Posix
=== RUN   TestAccTransfer_serial/User/UserNameValidation
=== RUN   TestAccTransfer_serial/User/basic
--- PASS: TestAccTransfer_serial (1149.02s)
    --- PASS: TestAccTransfer_serial/User (1149.02s)
        --- PASS: TestAccTransfer_serial/User/disappears (195.72s)
        --- PASS: TestAccTransfer_serial/User/tags (173.29s)
        --- PASS: TestAccTransfer_serial/User/HomeDirectoryMappings (203.65s)
        --- PASS: TestAccTransfer_serial/User/ModifyWithOptions (215.09s)
        --- PASS: TestAccTransfer_serial/User/Posix (163.18s)
        --- PASS: TestAccTransfer_serial/User/UserNameValidation (16.69s)
        --- PASS: TestAccTransfer_serial/User/basic (181.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	1159.365s
% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/basic\|TestAccTransfer_serial/Server/tags' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/basic\|TestAccTransfer_serial/Server/tags -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (368.29s)
    --- PASS: TestAccTransfer_serial/Server (368.29s)
        --- PASS: TestAccTransfer_serial/Server/tags (173.79s)
        --- PASS: TestAccTransfer_serial/Server/basic (194.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	373.688s

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. service/transcribe Issues and PRs that pertain to the transcribe service. service/transfer Issues and PRs that pertain to the transfer service. tags Pertains to resource tagging. labels Apr 3, 2023
@ewbankkit ewbankkit merged commit e6f582e into main Apr 3, 2023
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-t branch April 3, 2023 19:59
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 3, 2023
@ewbankkit ewbankkit changed the title Tech debt: Reduce tags boilerplate code - Plugin Framework resources t* (Phase 3c) Tech debt: Reduce tags boilerplate code - Plugin SDK resources t* (Phase 3c) Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. service/transcribe Issues and PRs that pertain to the transcribe service. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant