Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin SDK resources m* (Phase 3c) #30510

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin SDK resources m* (Phase 3c) #30510

merged 8 commits into from
Apr 6, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 6, 2023 •
edited
Loading

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=m... ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/m.../... -v -count 1 -parallel 2  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccMacieMemberAccountAssociation_basic
    member_account_association_test.go:22: Environment variable MACIE_MEMBER_ACCOUNT_ID is not set
--- SKIP: TestAccMacieMemberAccountAssociation_basic (0.00s)
=== RUN   TestAccMacieS3BucketAssociation_basic
=== PAUSE TestAccMacieS3BucketAssociation_basic
=== CONT  TestAccMacieS3BucketAssociation_basic
    s3_bucket_association_test.go:162: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://macie.us-west-2.amazonaws.com/": dial tcp: lookup macie.us-west-2.amazonaws.com: no such host
--- SKIP: TestAccMacieS3BucketAssociation_basic (24.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie	32.755s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	34.829s [no tests to run]
?   	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect	[no test files]
=== RUN   TestAccMediaConvertQueue_basic
=== PAUSE TestAccMediaConvertQueue_basic
=== CONT  TestAccMediaConvertQueue_basic
--- PASS: TestAccMediaConvertQueue_basic (46.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	66.742s
=== RUN   TestAccMediaLiveChannel_basic
=== PAUSE TestAccMediaLiveChannel_basic
=== RUN   TestAccMediaLiveInputSecurityGroup_basic
=== PAUSE TestAccMediaLiveInputSecurityGroup_basic
=== RUN   TestAccMediaLiveInput_basic
=== PAUSE TestAccMediaLiveInput_basic
=== CONT  TestAccMediaLiveChannel_basic
=== CONT  TestAccMediaLiveInput_basic
--- PASS: TestAccMediaLiveInput_basic (78.15s)
=== CONT  TestAccMediaLiveInputSecurityGroup_basic
--- PASS: TestAccMediaLiveChannel_basic (103.77s)
--- PASS: TestAccMediaLiveInputSecurityGroup_basic (26.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	140.603s
=== RUN   TestAccMediaPackageChannel_basic
=== PAUSE TestAccMediaPackageChannel_basic
=== RUN   TestAccMediaPackageChannel_tags
=== PAUSE TestAccMediaPackageChannel_tags
=== CONT  TestAccMediaPackageChannel_basic
=== CONT  TestAccMediaPackageChannel_tags
--- PASS: TestAccMediaPackageChannel_basic (50.76s)
--- PASS: TestAccMediaPackageChannel_tags (96.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage	112.618s
=== RUN   TestAccMediaStoreContainerPolicy_basic
=== PAUSE TestAccMediaStoreContainerPolicy_basic
=== RUN   TestAccMediaStoreContainer_basic
=== PAUSE TestAccMediaStoreContainer_basic
=== RUN   TestAccMediaStoreContainer_tags
=== PAUSE TestAccMediaStoreContainer_tags
=== CONT  TestAccMediaStoreContainerPolicy_basic
=== CONT  TestAccMediaStoreContainer_tags
--- PASS: TestAccMediaStoreContainerPolicy_basic (124.12s)
=== CONT  TestAccMediaStoreContainer_basic
--- PASS: TestAccMediaStoreContainer_tags (218.79s)
--- PASS: TestAccMediaStoreContainer_basic (174.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediastore	310.498s
=== RUN   TestAccMemoryDBACLDataSource_basic
=== PAUSE TestAccMemoryDBACLDataSource_basic
=== RUN   TestAccMemoryDBACL_basic
=== PAUSE TestAccMemoryDBACL_basic
=== RUN   TestAccMemoryDBACL_update_tags
=== PAUSE TestAccMemoryDBACL_update_tags
=== RUN   TestAccMemoryDBClusterDataSource_basic
=== PAUSE TestAccMemoryDBClusterDataSource_basic
=== RUN   TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== RUN   TestAccMemoryDBCluster_Update_tags
=== PAUSE TestAccMemoryDBCluster_Update_tags
=== RUN   TestAccMemoryDBParameterGroupDataSource_basic
=== PAUSE TestAccMemoryDBParameterGroupDataSource_basic
=== RUN   TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN   TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== RUN   TestAccMemoryDBSnapshotDataSource_basic
=== PAUSE TestAccMemoryDBSnapshotDataSource_basic
=== RUN   TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN   TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== RUN   TestAccMemoryDBSubnetGroupDataSource_basic
=== PAUSE TestAccMemoryDBSubnetGroupDataSource_basic
=== RUN   TestAccMemoryDBSubnetGroup_basic
=== PAUSE TestAccMemoryDBSubnetGroup_basic
=== RUN   TestAccMemoryDBSubnetGroup_update_tags
=== PAUSE TestAccMemoryDBSubnetGroup_update_tags
=== RUN   TestAccMemoryDBUserDataSource_basic
=== PAUSE TestAccMemoryDBUserDataSource_basic
=== RUN   TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN   TestAccMemoryDBUser_update_tags
=== PAUSE TestAccMemoryDBUser_update_tags
=== CONT  TestAccMemoryDBACLDataSource_basic
=== CONT  TestAccMemoryDBSnapshotDataSource_basic
--- PASS: TestAccMemoryDBACLDataSource_basic (151.27s)
=== CONT  TestAccMemoryDBSubnetGroup_update_tags
--- PASS: TestAccMemoryDBSubnetGroup_update_tags (77.52s)
=== CONT  TestAccMemoryDBUser_update_tags
--- PASS: TestAccMemoryDBUser_update_tags (102.51s)
=== CONT  TestAccMemoryDBUser_basic
--- PASS: TestAccMemoryDBUser_basic (61.50s)
=== CONT  TestAccMemoryDBUserDataSource_basic
--- PASS: TestAccMemoryDBUserDataSource_basic (59.37s)
=== CONT  TestAccMemoryDBCluster_Update_tags
--- PASS: TestAccMemoryDBCluster_Update_tags (1228.13s)
=== CONT  TestAccMemoryDBParameterGroup_update_tags
--- PASS: TestAccMemoryDBParameterGroup_update_tags (99.09s)
=== CONT  TestAccMemoryDBParameterGroup_basic
--- PASS: TestAccMemoryDBParameterGroup_basic (27.40s)
=== CONT  TestAccMemoryDBParameterGroupDataSource_basic
--- PASS: TestAccMemoryDBParameterGroupDataSource_basic (24.49s)
=== CONT  TestAccMemoryDBClusterDataSource_basic
--- PASS: TestAccMemoryDBSnapshotDataSource_basic (2250.57s)
=== CONT  TestAccMemoryDBCluster_basic
--- PASS: TestAccMemoryDBClusterDataSource_basic (1461.58s)
=== CONT  TestAccMemoryDBACL_update_tags
--- PASS: TestAccMemoryDBACL_update_tags (58.03s)
=== CONT  TestAccMemoryDBSubnetGroupDataSource_basic
--- PASS: TestAccMemoryDBSubnetGroupDataSource_basic (22.86s)
=== CONT  TestAccMemoryDBSubnetGroup_basic
--- PASS: TestAccMemoryDBSubnetGroup_basic (24.12s)
=== CONT  TestAccMemoryDBACL_basic
--- PASS: TestAccMemoryDBACL_basic (142.05s)
=== CONT  TestAccMemoryDBSnapshot_update_tags
--- PASS: TestAccMemoryDBCluster_basic (1648.41s)
=== CONT  TestAccMemoryDBSnapshot_basic
--- PASS: TestAccMemoryDBSnapshot_update_tags (2264.36s)
--- PASS: TestAccMemoryDBSnapshot_basic (2233.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	6160.791s
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaService_basic
=== PAUSE TestAccMetaService_basic
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaPartitionDataSource_basic (23.79s)
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaARNDataSource_basic (23.82s)
=== CONT  TestAccMetaService_basic
--- PASS: TestAccMetaRegionDataSource_basic (20.30s)
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaService_basic (20.57s)
=== CONT  TestAccMetaIPRangesDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_basic (21.56s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_basic (26.26s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (17.64s)
--- PASS: TestAccMetaRegionsDataSource_basic (18.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	126.762s
=== RUN   TestAccMQBrokerDataSource_basic
=== PAUSE TestAccMQBrokerDataSource_basic
=== RUN   TestAccMQBrokerInstanceTypeOfferingsDataSource_basic
=== PAUSE TestAccMQBrokerInstanceTypeOfferingsDataSource_basic
=== RUN   TestAccMQBroker_basic
=== PAUSE TestAccMQBroker_basic
=== RUN   TestAccMQBroker_tags
=== PAUSE TestAccMQBroker_tags
=== RUN   TestAccMQBroker_RabbitMQ_basic
=== PAUSE TestAccMQBroker_RabbitMQ_basic
=== RUN   TestAccMQConfiguration_basic
=== PAUSE TestAccMQConfiguration_basic
=== RUN   TestAccMQConfiguration_tags
=== PAUSE TestAccMQConfiguration_tags
=== CONT  TestAccMQBrokerDataSource_basic
=== CONT  TestAccMQBroker_RabbitMQ_basic
--- PASS: TestAccMQBroker_RabbitMQ_basic (906.49s)
=== CONT  TestAccMQBroker_basic
--- PASS: TestAccMQBrokerDataSource_basic (1127.18s)
=== CONT  TestAccMQBroker_tags
--- PASS: TestAccMQBroker_basic (993.31s)
=== CONT  TestAccMQConfiguration_tags
--- PASS: TestAccMQConfiguration_tags (55.54s)
=== CONT  TestAccMQBrokerInstanceTypeOfferingsDataSource_basic
--- PASS: TestAccMQBrokerInstanceTypeOfferingsDataSource_basic (15.24s)
=== CONT  TestAccMQConfiguration_basic
--- PASS: TestAccMQConfiguration_basic (28.63s)
--- PASS: TestAccMQBroker_tags (1061.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	2202.645s
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_basic
--- PASS: TestAccMWAAEnvironment_basic (3532.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	3542.413s

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/macie2 Issues and PRs that pertain to the macie2 service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/medialive Issues and PRs that pertain to the medialive service. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/mediastore Issues and PRs that pertain to the mediastore service. service/memorydb Issues and PRs that pertain to the memorydb service. service/mq Issues and PRs that pertain to the mq service. service/mwaa Issues and PRs that pertain to the mwaa service. labels Apr 6, 2023
@ewbankkit ewbankkit merged commit 9e19710 into main Apr 6, 2023
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-m branch April 6, 2023 17:22
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 6, 2023
This was referenced Apr 6, 2023
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Apr 7, 2023
Merged
Merged
Merged
Merged
This was referenced Apr 10, 2023
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. service/macie2 Issues and PRs that pertain to the macie2 service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/medialive Issues and PRs that pertain to the medialive service. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/mediastore Issues and PRs that pertain to the mediastore service. service/memorydb Issues and PRs that pertain to the memorydb service. service/mq Issues and PRs that pertain to the mq service. service/mwaa Issues and PRs that pertain to the mwaa service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.62.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit