Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dangling OS disk in TestAccMsSqlVirtualMachine_* #16519

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Apr 23, 2022

these tests TestAccMsSqlVirtualMachine_* are failing on main due to the dangling os disk on created by azurerm_virtual_machine. Fixing it by adding delete_os_disk_on_termination.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 23, 2022

Test result
image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @myc2h6o, LGTM 🥟

@stephybun stephybun merged commit 2e1263a into hashicorp:main Apr 25, 2022
@github-actions github-actions bot added this to the v3.4.0 milestone Apr 25, 2022
@myc2h6o myc2h6o deleted the mssql_test_1 branch April 26, 2022 02:42
@github-actions
Copy link

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants