Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade media API version from 2020-05-01 and 2021-05-01 to 2021-11-01 and 2022-08-01 #19623

Merged
merged 10 commits into from
Dec 15, 2022
Merged

upgrade media API version from 2020-05-01 and 2021-05-01 to 2021-11-01 and 2022-08-01 #19623

merged 10 commits into from
Dec 15, 2022

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Dec 9, 2022

Notes:

Test:

TF_ACC=1 go test -v ./internal/services/media -test.run=TestAccMediaServicesAccount_identity -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMediaServicesAccount_identity
=== PAUSE TestAccMediaServicesAccount_identity
=== CONT  TestAccMediaServicesAccount_identity
--- PASS: TestAccMediaServicesAccount_identity (441.22s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/media 442.385s

katbyte
katbyte requested changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have test failures:

image

@github-actions github-actions bot added documentation service/mssql Microsoft SQL Server labels Dec 15, 2022
katbyte
katbyte approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📺

@katbyte katbyte merged commit d0922a7 into hashicorp:main Dec 15, 2022
katbyte added a commit that referenced this pull request Dec 15, 2022
@katbyte
CHANGELOG #19623
b5dc9f0
@teowa
Copy link
Contributor Author

teowa commented Dec 16, 2022

image

favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@katbyte @favoretti
CHANGELOG hashicorp#19623
a027f00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies documentation service/media service/mssql Microsoft SQL Server size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teowa @katbyte