Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements for Certificate Authority #2883

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_privateca_certificate_authority_iam_policy
google_privateca_certificate_authority_iam_binding
google_privateca_certificate_authority_iam_member

This PR brings multiple UX improvements over the recently merged but unreleased GoogleCloudPlatform/magic-modules#4382. As such it would be nice if google_privateca_certificate_authority release waits to be released with these changes:

  1. Fix update.
  2. Mark multiple immutable fields as ForceNew.
  3. Small documentation improvements.
  4. Support for Customer-Managed Encryption Keys (CMEK).
  5. Adds a warning to the docs that CAs created during preview/terraform-provider-google-beta will be deleted before GA and should not be used in production (this note is already present in gcloud and the Console and was highlighted internally by the product team)
  6. Support for specifying reusableConfigs using the short form (in which case the Google-managed reusableConfig project is used.
  7. Adds a virtual attribute disable_on_delete that should be enabled to allow a CA to be deleted (same rationale of force_destroy on google_storage_bucket), and also only disable is the CA is in the enabled state.
  8. Adds support for SUBORDINATE CAs (activation should still be done manually via Console or gcloud, however).
  9. Adds IAM resources.

Derived from GoogleCloudPlatform/magic-modules#4407

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xxl label Jan 19, 2021
@modular-magician modular-magician merged commit 4b7dc8d into hashicorp:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant