Add Certificate Authority Resource (Certificate Authority Service) #4382

connorsmith-w · 2021-01-11T03:06:49Z

hashicorp/terraform-provider-google#7657

Adds "google_privateca_certificate_authority" (name is duplicated because "Certificate Authority" is also the product name)

See https://cloud.google.com/certificate-authority-service/docs/reference/rest/v1beta1/projects.locations.certificateAuthorities for resource documentation.

Notes:

This change doesn't implement support for subordinate CAs, which require additional customization because they must be activated.

Customizations:

Use POST :scheduleDelete to delete the resource (delete is not supported)
On pre_delete, POST :disable to disable the resources (required for scheduling deletion)
Check resource deletion by checking that status is DELETION_PENDING

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_privateca_certificate_authority`

modular-magician · 2021-01-11T03:07:58Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

modular-magician · 2021-01-11T03:15:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1857 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

drebes · 2021-01-11T14:56:29Z

Hi, I have some ongoing work for Private CA here, however I didn't have much time to progress recently. Would you like to pick up this work?

connorsmith-w · 2021-01-11T21:48:10Z

@drebes Updated to use "privateca" as the base name as discussed out of band.

modular-magician · 2021-01-11T21:54:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 710 insertions(+))
Terraform Beta: Diff ( 11 files changed, 3698 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 16 files changed, 516 insertions(+))

modular-magician · 2021-01-11T21:58:12Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 710 insertions(+))
Terraform Beta: Diff ( 11 files changed, 3698 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 16 files changed, 516 insertions(+))

In Certificate Authority Service (privateca). See https://cloud.google.com/certificate-authority-service/docs/reference/rest/v1beta1/projects.locations.certificateAuthorities for resource documentation. Notes: - This change doesn't implement support for subordinate CAs, which require additional customization because they must be activated. Customizations: - Use POST :scheduleDelete to delete the resource (delete is not supported) - On pre_delete, POST :disable to disable the resources (required for scheduling deletd) - Check resource deletion by checking that status is DELETION_PENDING

modular-magician · 2021-01-11T22:08:35Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1857 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

ScottSuarez

adding some comments... mainly just discrepancies between the live docs and your code. Some fields are stated as required in the docs and not included as parameters for the resource. I'm sure you know what you're doing though

products/privateca/api.yaml

ScottSuarez · 2021-01-13T14:52:44Z

/gcbrun

modular-magician · 2021-01-13T14:53:00Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166875"

modular-magician · 2021-01-13T15:00:50Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

modular-magician · 2021-01-13T16:28:27Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccInstanceTemplateDatasource_filter|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166877"

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

modular-magician · 2021-01-13T19:26:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1860 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

modular-magician · 2021-01-13T19:31:37Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1860 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

modular-magician · 2021-01-13T19:36:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1860 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

modular-magician · 2021-01-13T19:37:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 361 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1861 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

…eTime.

connorsmith-w · 2021-01-13T19:57:24Z

@ScottSuarez marked more fields required (now that I understand what input and required mean :) ), added createtime/updateTime, and addressed other comments. Thank you for the thorough review!

ScottSuarez · 2021-01-13T20:04:10Z

/gcbrun

modular-magician · 2021-01-13T20:04:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 372 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1903 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

modular-magician · 2021-01-13T20:04:24Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166923"

modular-magician · 2021-01-13T20:12:51Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 372 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1903 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 258 insertions(+))

modular-magician · 2021-01-13T20:15:06Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceComputeLbIpRanges_basic|TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceGoogleCloudRunService_basic|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDNSKeys_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleBillingAccount_byDisplayName|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleBillingAccount_byFullNameClosed|TestAccDataSourceGoogleClientConfig_basic|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceGoogleForwardingRule|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceComputeImageFilter|TestAccDataSourceComputeImage|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccInstanceTemplateDatasource_name|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeSslCertificate|TestAccDataSourceComputeNodeTypes_basic|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRegionSslCertificate|TestAccComputeRegions_basic|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccDataSourceGoogleSubnetwork|TestAccComputeZones_filter|TestAccDataSourceGoogleVpnGateway|TestAccComputeZones_basic|TestAccContainerClusterDatasource_zonal|TestAccContainerEngineVersions_basic|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_byFullName|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceIAMRole|TestAccDataSourceGoogleFolder_byFullNameNotFound|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleOrganization_byDomain|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleProject_basic|TestAccRedisInstanceDatasource_basic|TestAccDataSourceGoogleServiceAccountIdToken_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNoDisplayNameOrType|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotFound|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGooglePubsubTopic_basic|TestAccDatasourceSecretManagerSecretVersion_latest|TestAccDatasourceSecretManagerSecretVersion_basic|TestAccDataSourceGooglePubsubTopic_optionalProject You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166924"

connorsmith-w · 2021-01-13T20:24:18Z

It seems terraform did not like having "required: true" set for fields which also have a default_value. Fixed (and verified that local test passes for me).

modular-magician · 2021-01-13T20:32:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 375 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 261 insertions(+))

ScottSuarez · 2021-01-14T16:25:09Z

ahh cool cool, thanks for checking that ! sorry for the confusion I suppose we both learned something here ;)

/gcbrun

modular-magician · 2021-01-14T16:25:24Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167106"

modular-magician · 2021-01-14T16:34:04Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 375 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 261 insertions(+))

modular-magician · 2021-01-14T17:49:42Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccInstanceTemplateDatasource_filter|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167113"

connorsmith-w · 2021-01-14T19:55:06Z

@ScottSuarez do you know why generate-diffs may be failing? I don't seem to have the read ACL for it.

ScottSuarez · 2021-01-14T23:34:10Z

@ScottSuarez do you know why generate-diffs may be failing? I don't seem to have the read ACL for it.

i'm looking now... looks like linter rules. I'm asking my colleges

ScottSuarez · 2021-01-15T01:52:30Z

linting was broken for a 7m period due to a bad merge

/gcbrun

modular-magician · 2021-01-15T01:52:45Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167242"

modular-magician · 2021-01-15T02:00:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 375 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 261 insertions(+))

ScottSuarez · 2021-01-15T14:45:47Z

/gcbrun

modular-magician · 2021-01-15T14:46:02Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167303"

modular-magician · 2021-01-15T14:53:36Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 375 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 261 insertions(+))

modular-magician · 2021-01-15T16:27:44Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunServiceIamBindingGenerated|TestAccCloudRunServiceIamMemberGenerated|TestAccCloudRunServiceIamPolicyGenerated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudRunService_cloudRunServiceBasicExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunService_cloudRunServiceNoauthExample|TestAccComputeHealthCheck_tcp_update|TestAccComputeHealthCheck_typeTransition|TestAccComputeRegionBackendService_basic|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167306"

ScottSuarez · 2021-01-15T16:48:34Z

/gcbrun

had to enable the api on our test product. rerunning

modular-magician · 2021-01-15T16:48:48Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167311"

modular-magician · 2021-01-15T16:56:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 375 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1909 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 261 insertions(+))

modular-magician · 2021-01-15T17:55:26Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167319"

drebes · 2021-01-17T17:13:13Z

It would be great if we could hold release for this until #4407 is also merged.

google-cla bot added the cla: yes label Jan 11, 2021

modular-magician requested a review from ScottSuarez January 11, 2021 03:07

connorsmith-w force-pushed the certificateauthority branch from ce7ccc4 to 5201f61 Compare January 11, 2021 21:50

connorsmith-w force-pushed the certificateauthority branch from 5201f61 to 978bbe0 Compare January 11, 2021 22:00

ScottSuarez reviewed Jan 13, 2021

View reviewed changes

connorsmith-w and others added 2 commits January 13, 2021 11:18

Set key_spec input=true

bc84c97

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

Make algorithm required

933dad2

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

connorsmith-w and others added 2 commits January 13, 2021 11:28

Make include_ca_cert_url required.

48e0d25

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

Make include_crl_access_url required.

87e0006

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

Mark additional required fields as required, and add createTime/updat…

f99f307

…eTime.

Fix tests by removing required markers where default_value is also set.

384f223

ScottSuarez approved these changes Jan 15, 2021

View reviewed changes

ScottSuarez merged commit 6bff64b into GoogleCloudPlatform:master Jan 15, 2021

This was referenced Jan 15, 2021

Add Certificate Authority Resource (Certificate Authority Service) hashicorp/terraform-provider-google-beta#2877

Merged

Add Certificate Authority Resource (Certificate Authority Service) hashicorp/terraform-provider-google#8233

Merged

drebes mentioned this pull request Jan 17, 2021

Misc improvements for Certificate Authority #4407

Merged

5 tasks

This was referenced Jan 19, 2021

Misc improvements for Certificate Authority hashicorp/terraform-provider-google-beta#2883

Merged

Misc improvements for Certificate Authority hashicorp/terraform-provider-google#8249

Merged

Add Certificate Authority Resource (Certificate Authority Service) #4382

Add Certificate Authority Resource (Certificate Authority Service) #4382

Conversation

connorsmith-w commented Jan 11, 2021 • edited Loading

modular-magician commented Jan 11, 2021

modular-magician commented Jan 11, 2021

Diff report:

drebes commented Jan 11, 2021

connorsmith-w commented Jan 11, 2021

modular-magician commented Jan 11, 2021

Diff report:

modular-magician commented Jan 11, 2021

Diff report:

modular-magician commented Jan 11, 2021

Diff report:

ScottSuarez left a comment

Choose a reason for hiding this comment

ScottSuarez commented Jan 13, 2021

modular-magician commented Jan 13, 2021

modular-magician commented Jan 13, 2021

Diff report:

modular-magician commented Jan 13, 2021

modular-magician commented Jan 13, 2021

Diff report:

modular-magician commented Jan 13, 2021

Diff report:

modular-magician commented Jan 13, 2021

Diff report:

modular-magician commented Jan 13, 2021

Diff report:

connorsmith-w commented Jan 13, 2021

ScottSuarez commented Jan 13, 2021

modular-magician commented Jan 13, 2021

Diff report:

modular-magician commented Jan 13, 2021

modular-magician commented Jan 13, 2021

Diff report:

modular-magician commented Jan 13, 2021

connorsmith-w commented Jan 13, 2021

modular-magician commented Jan 13, 2021

Diff report:

ScottSuarez commented Jan 14, 2021

modular-magician commented Jan 14, 2021

modular-magician commented Jan 14, 2021

Diff report:

modular-magician commented Jan 14, 2021

connorsmith-w commented Jan 14, 2021

ScottSuarez commented Jan 14, 2021

ScottSuarez commented Jan 15, 2021

modular-magician commented Jan 15, 2021

modular-magician commented Jan 15, 2021

Diff report:

ScottSuarez commented Jan 15, 2021

modular-magician commented Jan 15, 2021

modular-magician commented Jan 15, 2021

Diff report:

modular-magician commented Jan 15, 2021

ScottSuarez commented Jan 15, 2021

modular-magician commented Jan 15, 2021

modular-magician commented Jan 15, 2021

Diff report:

modular-magician commented Jan 15, 2021

drebes commented Jan 17, 2021

connorsmith-w commented Jan 11, 2021 •

edited

Loading