-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle aggregatedList case for generated sweepers #5364
Merged
modular-magician
merged 23 commits into
hashicorp:downstream-master
from
modular-magician:downstream-pr-b66fd1d66acbe76821edcbaf8c068455e23a3a96
Jan 9, 2020
Merged
Handle aggregatedList case for generated sweepers #5364
modular-magician
merged 23 commits into
hashicorp:downstream-master
from
modular-magician:downstream-pr-b66fd1d66acbe76821edcbaf8c068455e23a3a96
Jan 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <magic-modules@google.com>
* Updated google_folder.html The page in the first example shows that you should use organization_id with value of 1234567. In the Import example, it's not clear whether organization_id is user, or folder_id is used. API call behind this import command is only accepting folder_id (can be checked when setting TF_LOG to trace and viewing the API call) * Update website/docs/r/google_folder.html.markdown Co-Authored-By: Dana Hoffman <danahoffman@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>
…icorp#5314) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>
Bug template changes
Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com>
…p#5316) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Martin Nowak <code@dawg.eu>
Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
…#5353) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com>
…#5355) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com>
Handle aggregatedList case for generated sweepers
ghost
added
the
size/xxl
label
Jan 9, 2020
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Feb 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5300
This PR includes:
skip_sweeper
flag from resources that use aggregatedList (generates 5 new sweepers)Edit:
Ran this PR in our CI, you can find the new sweepers running here.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#2941