Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certificate Authority Resource (Certificate Authority Service) #8233

Conversation

modular-magician
Copy link
Collaborator

#7657

Adds "google_privateca_certificate_authority" (name is duplicated because "Certificate Authority" is also the product name)

See https://cloud.google.com/certificate-authority-service/docs/reference/rest/v1beta1/projects.locations.certificateAuthorities for resource documentation.

Notes:

  • This change doesn't implement support for subordinate CAs, which require additional customization because they must be activated.

Customizations:

  • Use POST :scheduleDelete to delete the resource (delete is not supported)
  • On pre_delete, POST :disable to disable the resources (required for scheduling deletion)
  • Check resource deletion by checking that status is DELETION_PENDING

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_privateca_certificate_authority`

Derived from GoogleCloudPlatform/magic-modules#4382

…ashicorp#4382)

* Add resource google_privateca_certificate_authority

In Certificate Authority Service (privateca).

See
https://cloud.google.com/certificate-authority-service/docs/reference/rest/v1beta1/projects.locations.certificateAuthorities
for resource documentation.

Notes:
- This change doesn't implement support for subordinate CAs, which require
  additional customization because they must be activated.

Customizations:
- Use POST :scheduleDelete to delete the resource (delete is not supported)
- On pre_delete, POST :disable to disable the resources (required for scheduling
  deletd)
- Check resource deletion by checking that status is DELETION_PENDING

* Set key_spec input=true

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make algorithm required

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make include_ca_cert_url required.

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make include_crl_access_url required.

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Mark additional required fields as required, and add createTime/updateTime.

* Fix tests by removing required markers where default_value is also set.

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label Jan 15, 2021
@modular-magician modular-magician merged commit 4cf5036 into hashicorp:master Jan 15, 2021
@ghost
Copy link

ghost commented Feb 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant