-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump nokogiri dependency to the latest stable version #6848
Conversation
Hi @anatol Thank you for opening a pull request. What is the motivation for bumping this dependency? Is there a security vulnerability or a feature that we need? In general, we are very pessimistic about version constraints in Vagrant because we have been bitten in the past by tiny "patch" upgrades that introduce breaking changes. |
@sethvargo With the latest version of vagrant, nokogiri is now broken on windows. Nokogiri <1.6.7 does not support ruby 2.2 on windows and fails with the error that @NewyorkDev posted. I'm using a vagrant plugin that depends on nokogiri and vagrant, but I can't update the nokogiri version in the plugin since it creates incompatible dependencies between vagrant's nokogiri version and the changed version in the plugin. Is there a reason why nokogiri is listed as a dependency in vagrant at all? I can't seem to find any references to it in the codebase. I just really need this problem resolved either by updating to >1.6.7, or by removing it as a dependency, or by doing something else. |
The vagrant-vcloud plugin also suffers from this issue. I first thought it was an issue inside the plugin frapposelli/vagrant-vcloud#122 |
Any chance of getting vagrant 1.8.2 released with this patch? |
Have to use version 1.7.4 currently but need some of the bug fixes from 1.8.1 for other issues. |
Bump nokogiri dependency to the latest stable version
I think this is affecting vagrant-azure, too. Looking forward to getting this fix. |
Nokogiri in ruby 2.2 does not support Windows, and vagrant recently just merged a pull request to update the dependency to 1.6.7 (See hashicorp/vagrant#6848) This update enables people to use this plugin on windows with the most recent versions of vagrant. This should wait to be merged until the patch for vagrant is released.
Also vagrant-cloudstack is affected. Any idea when a new msi build is expected? As using Vagrant as a gem is not the way to go but is something I could build myself, is there some way (script/doc) I could make my own (unsupported/development) msi/distribution of current master? |
@sethvargo Thanks! |
@sethvargo As I need Vagrant from Kitchen, the binstubs (shebang ( |
Closes #6766