Update nokogiri to at least 1.6.7 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri in ruby 2.2 does not support Windows, and vagrant recently just merged a pull request to update the dependency to 1.6.7 (See hashicorp/vagrant#6848) This update enables people to use this plugin on windows with the most recent versions of vagrant. This should wait to be merged until the patch for vagrant is released.
|
Thanks for this. As you suggest, I'll leave this open for now. |
|
👍 |
|
@jonludlam Just a reminder that this is still an issue. I forgot to let you know that vagrant has released a dot version that contains the related fix hashicorp/vagrant@9af8266 (The fix is in both 1.8.3 and 1.8.4) Either my fix, or the more involved #30 could work, and I don't really know what the right way to handle this is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, sorry for the flood of pull requests I'm about to open. These are some changes that I made in order to get this plugin to work with our configuration.
Nokogiri in ruby 2.2 does not support Windows, and vagrant recently just
merged a pull request to update the dependency to 1.6.7
(See hashicorp/vagrant#6848 for more details)
This update enables people to use this plugin on windows with the most recent
versions of vagrant. This should wait to be merged until the patch for vagrant
is released.