Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Automatically refresh page on logout #12035

Merged
merged 8 commits into from
Jul 14, 2021
Merged

UI: Automatically refresh page on logout #12035

merged 8 commits into from
Jul 14, 2021

Conversation

hashishaw
Copy link
Contributor

When a Vault user logs out, automatically refresh the page by navigating to it with location.assign rather than using the router's replaceWith method.

@hashishaw hashishaw added this to the 1.6.6 milestone Jul 9, 2021
@vercel vercel bot temporarily deployed to Preview – vault July 9, 2021 19:59 Inactive
Monkeychip
Monkeychip approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done. Thank you for tackling!

@vercel vercel bot temporarily deployed to Preview – vault-storybook July 9, 2021 20:01 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 9, 2021 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 12, 2021 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 12, 2021 15:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 13, 2021 15:10 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 13, 2021 17:51 Inactive
Monkeychip
Monkeychip approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked out the branch and did some testing. looks good!

@hashishaw hashishaw merged commit 2e0dcb7 into main Jul 14, 2021
@hashishaw hashishaw deleted the ui/refresh-store-on-logout branch July 14, 2021 15:01
hashishaw added a commit that referenced this pull request Jul 14, 2021
@hashishaw
UI: Automatically refresh page on logout (#12035)
ebd3385
hashishaw added a commit that referenced this pull request Jul 14, 2021
@hashishaw
UI: Automatically refresh page on logout (#12035)
8fe0724
hashishaw added a commit that referenced this pull request Jul 14, 2021
@hashishaw
UI: Automatically refresh page on logout (#12035)
b52eeef
This was referenced Jul 14, 2021
Merged
Merged
Merged
hashishaw added a commit that referenced this pull request Jul 15, 2021
@hashishaw
UI: Automatically refresh page on logout (#12035) (#12080)
d7cb1ff
hashishaw added a commit that referenced this pull request Jul 15, 2021
@hashishaw
UI: Automatically refresh page on logout (#12035) (#12081)
e7cc5fc
hashishaw added a commit that referenced this pull request Jul 16, 2021
@hashishaw
UI: Automatically refresh page on logout (#12035) (#12082)
ed8d36b
@zofskeez zofskeez mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meirish meirish meirish left review comments

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport ui
Projects
None yet
Milestone
1.6.6
Development

Successfully merging this pull request may close these issues.
3 participants
@hashishaw @meirish @Monkeychip