-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logout with wrapped token #14329
Logout with wrapped token #14329
Conversation
} else { | ||
let params = `?with=${authType}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you have a namespace with a query param for a wrapped token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the auth-form
component, if wrappedToken
is provided it will automatically attempt to unseal the token and if successful it preforms the same action as if the form has been filled out and the user hits submit manually. If a namespace is present in the query param it should behave as if the user selected one in the dropdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is this a good candidate to add some test coverage for this scenario? Also does this need to be backported? I added the 1.10 release milestone as it's a bug. Not sure if this means we need to backport this to 1.10 or not because it's not rc-1.
I had a look and there were already Acceptance tests covering this, |
This fix addresses an issue with the
wrapped_token
query parameter not working with the logout route. The user was presented with the login form rather than attempting to unwrap the supplied token and login automatically.logout-wrapped-token.mp4