Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard occurrences of "." while backing up #7807

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

ptkato
Copy link
Collaborator

@ptkato ptkato commented Nov 9, 2021

Fixes #7806.


Please include the following checklist in your PR:

@Mikolaj
Copy link
Member

Mikolaj commented Nov 9, 2021

Is it easy to add the offending example as a test? I guess we don't need a changelog, because in 3.8 we both introduce the bug and fix it?

@ptkato
Copy link
Collaborator Author

ptkato commented Nov 9, 2021

It is, I'll add it as a test; Adding a test for that will take a bit of extra effort that I don't think that would fit in this PR proper, considering how FileCreators is laid out; also that's how I've been dealing with changelogs, since the feature + the bugfix will be in the same bag.

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we make it a habit that fixes come with a regression test?

@Mikolaj
Copy link
Member

Mikolaj commented Nov 10, 2021

A compromise we might have is to create a new PR that extend the testing framework and adds the test (marked as failing) and afterwards we could rebase this PR and see that the test passes (and unmark it). Any volunteers?

@ptkato
Copy link
Collaborator Author

ptkato commented Nov 10, 2021

@Mikolaj, uh, I volunteer, though I intended to proceed like that anyway.

@Mikolaj
Copy link
Member

Mikolaj commented Nov 10, 2021

@Mikolaj, uh, I volunteer, though I intended to proceed like that anyway.

Great minds think alike. :)

But I'm just confirming here, in particular for Andreas, who is not on Matrix/IRC, so didn't hear our conversation about this.

@ptkato ptkato mentioned this pull request Nov 23, 2021
3 tasks
@ptkato ptkato force-pushed the cabal-init-backup-fix branch from ebec713 to 95189ac Compare December 1, 2021 23:51
@ptkato
Copy link
Collaborator Author

ptkato commented Dec 1, 2021

Okay, the test is now in place. Any other paths that would be deemed invalid?

@Mikolaj
Copy link
Member

Mikolaj commented Dec 3, 2021

@andreasabel: I know you are busy right now and I think your feedback has been addressed, so if you don't object (in time), I will take the liberty of dismissing your review block. But we would love to hear any fresh feedback, of course. :)

@ptkato
Copy link
Collaborator Author

ptkato commented Dec 20, 2021

@Mikolaj, @andreasabel, I believe this is good to go, yes?

@Mikolaj
Copy link
Member

Mikolaj commented Dec 20, 2021

Yes, it is, but we need one more review.

@Mikolaj
Copy link
Member

Mikolaj commented Dec 22, 2021

@tchoutri, @Kleidukos: thank you! Let's get this beast merged.

@Mikolaj Mikolaj added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Dec 22, 2021
@ptkato ptkato force-pushed the cabal-init-backup-fix branch from 95189ac to bae93d1 Compare December 22, 2021 08:51
@mergify mergify bot merged commit 192a9c4 into haskell:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal init crashes with --source-dir=.
5 participants