-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cabal init
FileCreators tests
#7831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikolaj
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
ptkato
force-pushed
the
cabal-init-fileformat-tests
branch
from
November 25, 2021 00:05
9bd9b75
to
087929a
Compare
3 tasks
Kleidukos
requested changes
Nov 30, 2021
ptkato
force-pushed
the
cabal-init-fileformat-tests
branch
from
November 30, 2021 20:24
087929a
to
604e3c9
Compare
Kleidukos
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful :)
@ptkato Just take care of the conflict caused by the latest merge, and we should be good! :) |
ptkato
force-pushed
the
cabal-init-fileformat-tests
branch
from
November 30, 2021 21:38
604e3c9
to
f592992
Compare
ptkato
force-pushed
the
cabal-init-fileformat-tests
branch
from
December 1, 2021 02:23
f592992
to
cfb6018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts
cabal init
'sFileCreators
module, so it has the capability to be tested through the testing machinery proper. It is also a compromise for the stalemate in #7807, as it will be unblocked.Please include the following checklist in your PR: