Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal init FileCreators tests #7831

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

ptkato
Copy link
Collaborator

@ptkato ptkato commented Nov 23, 2021

This PR adapts cabal init's FileCreators module, so it has the capability to be tested through the testing machinery proper. It is also a compromise for the stalemate in #7807, as it will be unblocked.


Please include the following checklist in your PR:

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

@ptkato ptkato force-pushed the cabal-init-fileformat-tests branch from 9bd9b75 to 087929a Compare November 25, 2021 00:05
@ptkato ptkato force-pushed the cabal-init-fileformat-tests branch from 087929a to 604e3c9 Compare November 30, 2021 20:24
Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful :)

@Kleidukos
Copy link
Member

@ptkato Just take care of the conflict caused by the latest merge, and we should be good! :)

@ptkato ptkato force-pushed the cabal-init-fileformat-tests branch from 604e3c9 to f592992 Compare November 30, 2021 21:38
@ptkato ptkato added the merge me Tell Mergify Bot to merge label Dec 1, 2021
@ptkato ptkato force-pushed the cabal-init-fileformat-tests branch from f592992 to cfb6018 Compare December 1, 2021 02:23
@mergify mergify bot merged commit d0b35b4 into haskell:master Dec 1, 2021
@ptkato ptkato changed the title Cabal init fileformat tests cabal init FileCreators tests Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants