Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend library to executable deps in cabal init #7839

Merged
merged 2 commits into from
Nov 27, 2021
Merged

Prepend library to executable deps in cabal init #7839

merged 2 commits into from
Nov 27, 2021

Conversation

ptkato
Copy link
Collaborator

@ptkato ptkato commented Nov 26, 2021 •
edited
Loading

Fixes #7836. Testing depends on #7831.

Please include the following checklist in your PR:

Mikolaj
Mikolaj approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptkato ptkato force-pushed the cabal-init-libexe-dep branch from c28f763 to 1331e16 Compare November 26, 2021 21:51
@ptkato
Copy link
Collaborator Author

ptkato commented Nov 26, 2021

@Mikolaj I changed the approach to the problem, can you re-review, pretty please? By the by, thank you for the heads-up @emilypi

I'll be adding a test for this case specifically, since now it doesn't rely on the FileCreators tests.

Mikolaj
Mikolaj approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@ptkato ptkato force-pushed the cabal-init-libexe-dep branch from 1331e16 to b67ea24 Compare November 26, 2021 22:36
@ptkato ptkato force-pushed the cabal-init-libexe-dep branch from b67ea24 to 3d61cfa Compare November 26, 2021 22:38
@ptkato ptkato added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Nov 26, 2021
@mergify mergify bot merged commit 68c2c75 into haskell:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilypi emilypi emilypi approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-interactive use leads to executable missing the project as a build dependency
3 participants
@ptkato @Mikolaj @emilypi