#8975, #8981, #8983 rebased #9051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikolaj
approved these changes
Jun 20, 2023
ulysses4ever
approved these changes
Jun 20, 2023
|
We should not forget to close the base PRs when this one is merged... |
ulysses4ever
added
the
merge delay passed
|
I'm putting the delay-passed passed label because the actual changes have been reviewed in the past and this PR is only a tool to make sure those change land on |
This helps disabling individual packages (e.g. cabal-testsuite)
This is affect of using indentOfAtLeast method: any indentation greater than current offset is fine. That behavior is desirable to parsing multiline field contents, but it is a bit surprising for fields, which we expect to be aligned. Such insonsistency seems to be always a mistake, and it's easy to fix once a machine points it out.
As it runs fourmolu only on modified files, it's a lot faster.
For example `parseGenericPackageDescription` validates input it passes to `readFields'`. That is desirable: we want try to parse non-UTF8 inputs, and report as a warning if they are not UTF8. (There are non-UTF8 .cabal files on Hackage, e.g. with German names).
This was referenced Jun 22, 2023
Closed
|
Well done. Thank you again. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8975, #8981 and #8983, cherry picked.
Please include the following checklist in your PR:
Bonus points for added automated tests!