Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8975, #8981, #8983 rebased #9051

Merged
merged 5 commits into from
Jun 22, 2023
Merged

#8975, #8981, #8983 rebased #9051

merged 5 commits into from
Jun 22, 2023

Commits on Jun 22, 2023

  1. Split packages into separate entries 

    This helps disabling individual packages (e.g. cabal-testsuite)
    @phadej @ffaf1
    phadej authored and ffaf1 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    d78092a View commit details
    Browse the repository at this point in the history

  2. More correct position calculating in lexer after BOM and NBSPs.

    @phadej @ffaf1
    phadej authored and ffaf1 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    aaab541 View commit details
    Browse the repository at this point in the history

  3. Make readFields warn about inconsistent indentation. 

    This is affect of using indentOfAtLeast method:
any indentation greater than current offset is fine.

That behavior is desirable to parsing multiline field contents,
but it is a bit surprising for fields, which we expect to be aligned.

Such insonsistency seems to be always a mistake, and it's easy to fix once
a machine points it out.
    @phadej @ffaf1
    phadej authored and ffaf1 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3e17cec View commit details
    Browse the repository at this point in the history

  4. Add make style-modified 

    As it runs fourmolu only on modified files, it's a lot faster.
    @phadej @ffaf1
    phadej authored and ffaf1 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c116195 View commit details
    Browse the repository at this point in the history

  5. Document that readFields expects input to be UTF8 

    For example `parseGenericPackageDescription` validates input it passes to `readFields'`.

That is desirable: we want try to parse non-UTF8 inputs, and report as a warning if they are not UTF8. (There are non-UTF8 .cabal files on Hackage, e.g. with German names).
    @phadej @ffaf1
    phadej authored and ffaf1 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    117ea70 View commit details
    Browse the repository at this point in the history