Support ghc-9.2.3 #2936
Support ghc-9.2.3 #2936
Conversation
July541
requested review from
jneira,
Anton-Latukha,
Ailrun,
georgefst and
pepeiborra
as code owners
| -- for brittany | ||
| -- https://github.com/lspitzner/multistate/pull/8 | ||
| multistate:base, | ||
| -- https://github.com/lspitzner/data-tree-print/pull/3 | ||
| data-tree-print:base, | ||
| -- https://github.com/lspitzner/butcher/pull/8 | ||
| butcher:base, | ||
|
|
||
| -- for shake-bench | ||
| Chart:lens, | ||
| Chart-diagrams:lens, | ||
|
|
||
| -- for ekg | ||
| ekg-core:base, | ||
| ekg-core:ghc-prim, | ||
| ekg-wai:base, | ||
| ekg-wai:time, | ||
|
|
||
| -- for shake-bench | ||
| Chart-diagrams:diagrams-core, | ||
| SVGFonts:diagrams-core |
Following https://haskell-language-server.readthedocs.io/en/latest/supported-versions.html#minor-versions, it says "For the latest supported major GHC version we will support at least 2 minor versions". I think the "2 minor versions" means 9.2.2 and 9.2.3. |
|
stack build failed because hackage doesn't have ghc-9.2.3 yet, let's wait for it. |
|
Great stuff!
Might need to prod the GHC devs about this, they sometimes forget to upload it. |
Done. https://gitlab.haskell.org/ghc/ghc/-/issues/21326#note_434846 |
We temporarily pull from github:July541/haskell-language-server/ghc-9.2.3, until this PR is merged upstream: haskell/haskell-language-server#2936 However, more importantly, we re-use the `nonReinstallablePkgs` from input-output-hk/haskell.nix#1177 to fix a crash that has been plaguing us since we switched the GHC 9.2.3.
|
Nightly for GHC-9.2.3 is already on Stackage. Is this PR ready to be merged? |
|
We should merge #2944 first because build with ghc-9.2.3 will choose fourmolu-0.7.0.0. |
|
|
Hopefully fixed in #2950. |
It's merged! Hopefully this PR is now good to go (after incorporating |
|
👀 |
|
Great! Time for a new release? 😉 |
As you may saw, hls is trying some improvements recently, and it may be worth waiting until they are ready :) |
* Support ghc-9.2.3 * ormolu-0.5 * Update stack.yaml Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Dropped ghc-8.10.6 and ghc-9.0.1, keep supporting ghc-9.2.2.