Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ghc 9.2.3 #3117

Merged
merged 1 commit into from
Aug 15, 2022
Merged

update to ghc 9.2.3 #3117

merged 1 commit into from
Aug 15, 2022

Conversation

aryairani
Copy link
Contributor

@aryairani aryairani commented Jun 15, 2022

pins monad-validate at hasura/monad-validate#5 and sets ghc 9.2.3 via resolver: nightly-2022-06-15


This change is Reviewable

@aryairani aryairani changed the base branch from trunk to 21-10-04-optimize-add-tmp June 15, 2022 20:05
@aryairani aryairani changed the base branch from 21-10-04-optimize-add-tmp to trunk June 15, 2022 20:05
@aryairani
Copy link
Contributor Author

aryairani commented Jun 15, 2022

I guess enlil will need the same treatment at some point.

@aryairani
Copy link
Contributor Author

hls 1.7.0 doesn't support 9.2.3 anyway

@mitchellwrosen
Copy link
Member

hls 1.7.0 doesn't support 9.2.3 anyway

Oh, yeah... but it does support 9.2.2 according to: https://github.com/haskell/haskell-language-server/releases

Maybe we should pin to 9.2.2 instead, then?

@aryairani
Copy link
Contributor Author

aryairani commented Jun 15, 2022

Yeah, I will try that.

There are some deprecation warnings to deal with regardless, including calls to pTrace etc. that I'm not sure how to handle? Apparently it doesn't want to be in production code at all. I can disable deprecation warnings in that module, but...

Also hls has 9.2.3 forthcoming haskell/haskell-language-server#2936

@aryairani aryairani marked this pull request as draft June 16, 2022 18:01
@ChrisPenner ChrisPenner marked this pull request as ready for review August 11, 2022 15:24
@ChrisPenner ChrisPenner marked this pull request as draft August 11, 2022 15:24
@ChrisPenner ChrisPenner merged commit 0d04a2d into trunk Aug 15, 2022
@ChrisPenner ChrisPenner deleted the topic/ghc-9.2.3 branch August 15, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants