Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SingleStore connector #257

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Add SingleStore connector #257

merged 8 commits into from
Sep 2, 2024

Conversation

AdalbertMemSQL
Copy link
Contributor

This PR adds singlestore connector.

praveenweb
praveenweb reviewed Aug 22, 2024
View reviewed changes
registry/hasura/singlestore/README.md Outdated
@@ -0,0 +1,147 @@
# SingleStore Data Connector

![Logo Image](docs/singlestore_logo_horizontal_color_on-white_rgb.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdalbertMemSQL - Are you sure about the image URL? I'm guessing it is the relative URL to logo.png in the singlestore directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I will fix this

praveenweb
praveenweb approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codingkarthik codingkarthik mentioned this pull request Aug 29, 2024
Merged
codingkarthik added a commit that referenced this pull request Sep 2, 2024
@codingkarthik
Allow forked PRs to deploy connector version publishing in the stagin…
6664700 
…g environment (#268)

This PR extends the `registry-updates` workflow to access the repository
secrets for forked repository PRs, like this
[one](#257) .

It should be noted that, we are allowing this only for the staging
environment and this is not needed for the production environment.
@codingkarthik codingkarthik merged commit df6b987 into hasura:main Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingkarthik codingkarthik codingkarthik approved these changes

@praveenweb praveenweb Awaiting requested review from praveenweb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdalbertMemSQL @praveenweb @codingkarthik