Allow forked PRs to deploy connector version publishing in the staging environment #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I can change the workflow to run after the PR is approved. Basically, the idea initially was for the connector authors to re-iterate on the PR until they are satisfied with the changes, but I don't think it happens a lot, so we can totally make this change. |
| if: steps.check-approval.outputs.approved == 'false' | ||
| run: | | ||
| echo "The PR has not been approved. Cancelling the workflow." | ||
| exit 1 # This will exit the workflow early |
There was a problem hiding this comment.
will this show the workflow run as failed?
There was a problem hiding this comment.
Yes, until the PR is not approved the workflow will be shown as failed.
imperfect-fourth
approved these changes
Sep 2, 2024
codingkarthik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
registry-updatesworkflow to access the repository secrets for forked repository PRs, like this one .It should be noted that, we are allowing this only for the staging environment and this is not needed for the production environment.