Handle NotImplementedError when creating symlink on install; fixes py…

…thon-poetry#4626
havocbane · Oct 14, 2021 · 055a499 · 055a499
1 parent 82459bd
commit 055a499
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -23,7 +23,7 @@ jobs:
     strategy:
       matrix:
         os: [Ubuntu, MacOS, Windows]
-        python-version: [3.6, 3.7, 3.8, 3.9]
+        python-version: ["3.6", "3.7", "3.8", "3.9", "pypy-3.7"]
         experimental: [false]
         bootstrap-args: [""]
         include:

diff --git a/install-poetry.py b/install-poetry.py
@@ -558,9 +558,10 @@ def make_bin(self, version: str) -> None:
             self._bin_dir.joinpath(script).symlink_to(
                 self._data_dir.joinpath(target_script)
             )
-        except OSError:
-            # This can happen if the user
-            # does not have the correct permission on Windows
+        except (NotImplementedError, OSError):
+            # This can happen if the user does not have the correct permission
+            # or if they are using PyPy which does not implement symlink on
+            # Windows.
             shutil.copy(
                 self._data_dir.joinpath(target_script), self._bin_dir.joinpath(script)
             )