Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symlink can raise NotImplementedError #4626

Open
2 of 3 tasks
mattip opened this issue Oct 12, 2021 · 0 comments
Open
2 of 3 tasks

symlink can raise NotImplementedError #4626

mattip opened this issue Oct 12, 2021 · 0 comments
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@mattip
Copy link

mattip commented Oct 12, 2021

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: windows
  • Poetry version: HEAD
  • Link of a Gist with the contents of your pyproject.toml file:

Issue

PyPy does not yet implement os.symlink on windows. If poetry wishes to support PyPy on windows, this line needs to also trap NotImplementedError

poetry/install-poetry.py

Line 561 in 656c71d

except OSError:

@mattip mattip added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Oct 12, 2021
havocbane added a commit to havocbane/poetry that referenced this issue Oct 12, 2021
@havocbane
Handle NotImplementedError when creating symlink on install; fixes py…
42d3efe 
…thon-poetry#4626
@havocbane havocbane mentioned this issue Oct 12, 2021
Closed
2 tasks
havocbane added a commit to havocbane/poetry that referenced this issue Oct 14, 2021
@havocbane
Handle NotImplementedError when creating symlink on install; fixes py…
055a499 
…thon-poetry#4626
havocbane added a commit to havocbane/poetry that referenced this issue Oct 29, 2021
@havocbane
installer: handle NotImplementedError on symlink
1207ec4 
Resolves: python-poetry#4626
havocbane added a commit to havocbane/poetry that referenced this issue Oct 31, 2021
@havocbane
installer: handle NotImplementedError on symlink
3b84b40 
Resolves: python-poetry#4626
hoefling added a commit to hoefling/devpi-client-extensions that referenced this issue Apr 15, 2022
@hoefling
skip win + pypy3 builds due to python-poetry/poetry#4626
f9563b1 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
hoefling added a commit to hoefling/devpi-client-extensions that referenced this issue Aug 22, 2022
@hoefling
skip win + pypy3 builds due to python-poetry/poetry#4626
7a43205 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
hoefling added a commit to hoefling/devpi-client-extensions that referenced this issue Aug 22, 2022
@hoefling
don't run the ci twice per each pull request (#72)
804b9a7 
* don't run the ci twice per each pull request

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>

* try out running ci with pypy 3.9

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>

* remove workaround for python-poetry/poetry#4210

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>

* skip win + pypy3 builds due to python-poetry/poetry#4626

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>

* drop 3.6 jobs

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle NotImplementedError when creating symlink on install; fixes #4626 havocbane/poetry
1 participant
@mattip