Replace Debian Java requirement with an available version [DI-337] #240

JackPGreen · 2024-11-07T16:56:56Z

In #195, Debian was intended to upgrade it's dependant JRE to 21 - but the JDK specified does not exist (docker run --interactive --rm debian:stable bash -c "apt-get update && apt list | grep jdk")

Instead we should request the latest JDK which currently is 17 (docker run --interactive --rm debian:stable bash -c "apt-get update && apt-get install -y default-jdk-headless && java -version").

Fixes: #237, DI-337

Post-merge action:

backport to maintenance branches
copy to management centre

In #195, Debian was _intended_ to upgrade it's dependant JRE to `21` - but the JDK specified does not exist (`docker run --interactive --rm debian:stable bash -c "apt-get update && apt list | grep jdk"`) Instead we should request the _latest_ JDK which currently is `17` (`docker run --interactive --rm debian:stable bash -c "apt-get update && apt-get install -y default-jdk-headless && java -version"`). Fixes: #237

nishaatr · 2024-11-08T09:17:15Z

packages/deb/hazelcast/DEBIAN/control

@@ -5,7 +5,7 @@ Section: imdg
 Priority: optional
 Architecture: all
 Conflicts: ${CONFLICTS}
-Depends: java21-sdk-headless
+Depends: java21-sdk-headless | default-jdk-headless


What if default-jdk-headless ends up being beyond JDK21 when they finally update?

If there is no java21-sdk-headless, there are various outcomes:

we don't specify a fallback default-jdk-headless (current behaviour), you can't use Hazelcast (👎)

we specify a fallback default-jdk-headless

it's older

it's too old, Hazelcast doesn't work (👎)

it's old, but not too old (e.g. 17) - Hazelcast works (👍)

it's 21 - Hazelcast works (👍)

it's newer

(say) 22 is close enough - Hazelcast works (👍)

it's too new (say 99), Hazelcast doesn't work (👎)

At least this way there's a chance it works.

At least this way there's a chance it works.

Yes totally agree but if its >21 than this will break our Java policy and if it doesn't work then we are back to current situation

Wondering why this was not flagged with PR builder or something? Not sure I fully grasp #237. Is this compile or runtime issue?

I think if we can't guarantee default-jdk-headless will confirm to our Java policy than may be just use JDK17?

At least this way there's a chance it works.

Yes totally agree but if its >21 than this will break our Java policy and if it doesn't work then we are back to current situation

The other alternatives are that:

We don't list a JDK as a prerequisite and let the users install it themselves

We leave as-is and Debian is broken until they include JDK21 (which might be a while)

Wondering why this was not flagged with PR builder or something?
Because we test our Debian packages on Ubuntu, where there is a java21-sdk-headless.
I'm investigating this seperately.

Not sure I fully grasp #237. Is this compile or runtime issue?

It's an installation issue (which I guess for this project would be defined as runtime).
When you install Hazelcast, it should install the listed prerequisites as well. But they aren't available, so the installation fails.

I think if we can't guarantee default-jdk-headless will confirm to our Java policy than may be just use JDK17?

But then our JDKs are inconsistent between platforms... (no right answers here).

But then our JDKs are inconsistent between platforms... (no right answers here).

Yes very true.

May be Depends: java21-sdk-headless | java17-sdk-headless so its pinned either way?
In Docker we don't set default and I assume we will update all JDK usages when we update our Java policy

Just wondering if there a way to install JDk21 from a different location?

I am just giving my novice 2 cents so lets see what @ldziedziul has to say.

Just wondering if there a way to install JDk21 from a different location?

There is, but as it's not via apt I don't think you can tag it as a pre-requisite the same way so not useful for our purposes.

Needs backporting?

Needs backporting?

Yes - already in the description.

JackPGreen · 2024-11-18T09:06:47Z

@ldziedziul are you able to take a look at this, please?

ldziedziul

The other alternatives are that:

We don't list a JDK as a prerequisite and let the users install it themselves
We leave as-is and Debian is broken until they include JDK21 (which might be a while)

These options break user experience completely.

I think that default-jdk-headless as a fallback makes sense, and usually we end up with version between it's old, but not too old and it's new, but not too new which IMHO is acceptable. But I think the final decision should be agreed with @ElysePrid-Hazel. Also this brings the question if we should mentions this quirk in the docs

EDIT: One other idea would be to simply support ubuntu not debian

ElysePrid-Hazel · 2024-11-27T17:24:09Z

I think for this scenario we should go ahead and add the fallback, it adds more value than not and the work is completed.
Regarding Ubuntu that is a separate conversation and strategy which we can discuss.

Replicate hazelcast/hazelcast-packaging#240 for Management Center.

In #195, Debian was _intended_ to upgrade it's dependant JRE to `21` - but the JDK specified does not exist (`docker run --interactive --rm debian:stable bash -c "apt-get update && apt list | grep jdk"`) Instead we should request the _latest_ JDK which currently is `17` (`docker run --interactive --rm debian:stable bash -c "apt-get update && apt-get install -y default-jdk-headless && java -version"`). Fixes: #237

….4.z] (#243) Backport of: - #240 - #241

….5.z] (#244) Backport of: - #240 - #241

Replicate hazelcast/hazelcast-packaging#240 for Management Center. Fixes: [DI-337](https://hazelcast.atlassian.net/browse/DI-337) [DI-337]: https://hazelcast.atlassian.net/browse/DI-337?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

….4] (#45) Backport of #44 Replicate hazelcast/hazelcast-packaging#240 for Management Center. Fixes: [DI-337](https://hazelcast.atlassian.net/browse/DI-337) [DI-337]: https://hazelcast.atlassian.net/browse/DI-337?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

….5] (#46) Backport of #44 Replicate hazelcast/hazelcast-packaging#240 for Management Center. Fixes: [DI-337](https://hazelcast.atlassian.net/browse/DI-337) [DI-337]: https://hazelcast.atlassian.net/browse/DI-337?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

….6] (#47) Backport of #44 Replicate hazelcast/hazelcast-packaging#240 for Management Center. Fixes: [DI-337](https://hazelcast.atlassian.net/browse/DI-337) [DI-337]: https://hazelcast.atlassian.net/browse/DI-337?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

JackPGreen requested review from ldziedziul and nishaatr November 7, 2024 16:56

JackPGreen self-assigned this Nov 7, 2024

JackPGreen enabled auto-merge (squash) November 7, 2024 17:05

Add fallback default

cc6d240

nishaatr requested changes Nov 8, 2024

View reviewed changes

JackPGreen changed the title ~~Replace Debian Java requirement with an available version~~ Replace Debian Java requirement with an available version [DI-337] Nov 8, 2024

JackPGreen requested a review from nishaatr November 18, 2024 09:06

ldziedziul reviewed Nov 20, 2024

View reviewed changes

ldziedziul requested a review from ElysePrid-Hazel November 20, 2024 09:27

ldziedziul approved these changes Nov 27, 2024

View reviewed changes

nishaatr approved these changes Nov 28, 2024

View reviewed changes

JackPGreen merged commit 82d9c00 into master Nov 28, 2024
36 checks passed

JackPGreen deleted the debian-jdk-fix branch November 28, 2024 09:39

JackPGreen added a commit to hazelcast/management-center-packaging that referenced this pull request Nov 28, 2024

Replace Debian Java requirement with an available version [DI-337]

8caea87

Replicate hazelcast/hazelcast-packaging#240 for Management Center.

JackPGreen mentioned this pull request Nov 28, 2024

Replace Debian Java requirement with an available version [DI-337] hazelcast/management-center-packaging#44

Merged

1 task

This was referenced Nov 28, 2024

Replace Debian Java requirement with an available version [DI-337] [5.4.z] #243

Merged

Replace Debian Java requirement with an available version [DI-337] [5.5.z] #244

Merged

JackPGreen added a commit that referenced this pull request Nov 28, 2024

Replace Debian Java requirement with an available version [DI-337] [5…

b383bb8

….4.z] (#243) Backport of: - #240 - #241

JackPGreen added a commit that referenced this pull request Nov 28, 2024

Replace Debian Java requirement with an available version [DI-337] [5…

60e1996

….5.z] (#244) Backport of: - #240 - #241

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Debian Java requirement with an available version [DI-337] #240

Replace Debian Java requirement with an available version [DI-337] #240

JackPGreen commented Nov 7, 2024 •

edited

Loading

nishaatr Nov 8, 2024

JackPGreen Nov 8, 2024

nishaatr Nov 8, 2024

JackPGreen Nov 8, 2024

nishaatr Nov 8, 2024

JackPGreen Nov 8, 2024

nishaatr Nov 8, 2024

JackPGreen Nov 8, 2024

JackPGreen commented Nov 18, 2024

ldziedziul left a comment •

edited

Loading

ElysePrid-Hazel commented Nov 27, 2024

Replace Debian Java requirement with an available version [DI-337] #240

Replace Debian Java requirement with an available version [DI-337] #240

Conversation

JackPGreen commented Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JackPGreen commented Nov 18, 2024

ldziedziul left a comment • edited Loading

Choose a reason for hiding this comment

ElysePrid-Hazel commented Nov 27, 2024

JackPGreen commented Nov 7, 2024 •

edited

Loading

ldziedziul left a comment •

edited

Loading